Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staggered pf #2051

Closed
wants to merge 4 commits into from
Closed

Staggered pf #2051

wants to merge 4 commits into from

Conversation

KeitaYoshioka
Copy link
Contributor

Phase field for staggered FEM has been implemented. Two test cases can be found under Tests/Data/PhaseField

{
DBUG("AssembleJacobian PhaseFieldProcess for the monolithic scheme.");
dof_tables.emplace_back(*_local_to_global_index_map);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if-else-block for dof-table creation seems to be identical to the one in assembleConcreteProcess(). Could this duplication be avoided?

Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for the first PR!

A ctest is missing;

A short description of the test would be nice on the benchmark pages---let's have a look together on this.

@endJunction
Copy link
Member

docu for benchmarks is in web/content/docs/benchmarks

@endJunction
Copy link
Member

Superseded by #2052

@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants