Richards and material models #2188
Conversation
| (capillary_pressure < 0.0) ? _minor_offset : capillary_pressure; | ||
| double Se = std::pow(pc / _pb, 1.0 / (1.0 - _m)) + 1.0; | ||
| Se = std::pow(Se, -_m); | ||
| const double pc = std::max(_minor_offset, capillary_pressure); |
There was a problem hiding this comment.
The previous expression and the new one are not equal. For instance if capillary_pressure = 0.1 and _minor_offset = 0.5 the previous expression set pc to 0.1 while the new expression results in pc = 0.5. Is this intended?
There was a problem hiding this comment.
Intended. This moves the cutoff to correct point; the pc value is set to "minor_offset" not only for non-positive values, but for pc < minor_offset.
With capillary_pressure(x) = x, minor_offset = 0.1, the pc(x = 0.05) = 0.05 in the previous implementation, now it is does not have this "negative tooth" between x = 0 and 0.1.
| @@ -77,6 +76,11 @@ double VanGenuchtenCapillaryPressureSaturation::getdPcdS( | |||
|
|
|||
| return -getdPcdSvGBar(1 - _saturation_r); | |||
| } | |||
| if (saturation < _saturation_r) | |||
| return 0; | |||
There was a problem hiding this comment.
Is _saturation_r a lower bound? Then I would expect to set the saturation to _saturation_r.
There was a problem hiding this comment.
This one is indeed correct: there is a cut-off in the function for s < s_r, so the derivative (this function) is 0.
| if (saturation < _saturation_r) | ||
| return 0; | ||
| if (saturation > _saturation_max) | ||
| return 0; |
There was a problem hiding this comment.
Same cut-off in function => derivative = 0
| if (_has_regularized) | ||
| { | ||
| OGS_FATAL("Not implemented."); | ||
| /* |
There was a problem hiding this comment.
What is the plan for the commented code? Is it a suggestion for the implementation?
There was a problem hiding this comment.
Fixing... Added a descriptive error message. Removed the commented section.
endJunction
force-pushed
the
RichardsAndMaterialModels
branch
3 times, most recently
from
3ba68e8
to
2dc97b7
Compare
... and also comments.
One is the d permeability / d saturation, another is the second derivative d^2 p_cap / dS^2
endJunction
force-pushed
the
RichardsAndMaterialModels
branch
from
2dc97b7
to
9cecfe4
Compare
|
OpenGeoSys development has been moved to GitLab. |
A set of smaller fixes and extension of the unsaturated material model by permeability derivative and second derivative of capillary pressure wrt saturation. The derivatives are used in the RichardsMechanics process implementation in the following PR.