Partition boundary meshes properties #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bilke Jenkins docker-conan failed again with |
TomFischer
reviewed
Aug 28, 2018
| auto const n_local_ghost_elements = local_ghost_elements.size(); | ||
| for (std::size_t e = 0; e < n_local_ghost_elements; ++e) | ||
| { | ||
| bulk_element_ids[offset + n_local_regular_elements + |
There was a problem hiding this comment.
You could update the offset before the for-loop: offset += n_local_regular_elements; and write here and in line 597 only offset + e.
TomFischer
reviewed
Aug 28, 2018
| bulk_element_ids[offset + n_local_regular_elements + | ||
| e] = global_to_local | ||
| [bulk_element_ids[offset + n_local_regular_elements + e]]; | ||
| } |
There was a problem hiding this comment.
The loops for the regular and the ghost elements look very similar. Maybe a lambda can be called twice?
endJunction
force-pushed
the
PartitionBoundaryMeshesProperties
branch
2 times, most recently
from
19e9f26
to
bbb4dfb
Compare
|
@wenqing Maybe you want to have a look before I merge it (let's say on Wednesday). |
endJunction
force-pushed
the
PartitionBoundaryMeshesProperties
branch
from
bbb4dfb
to
22548c4
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.