Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition boundary meshes properties #2195

Merged
merged 8 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@endJunction
Copy link
Member

endJunction commented Aug 27, 2018

No description provided.

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Aug 27, 2018

@bilke Jenkins docker-conan failed again with

wrapper script does not seem to be touching the log file in /h/j/...@tmp/durable-87482286
(JENKINS-48300: if on a laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=300)
auto const n_local_ghost_elements = local_ghost_elements.size();
for (std::size_t e = 0; e < n_local_ghost_elements; ++e)
{
bulk_element_ids[offset + n_local_regular_elements +

This comment has been minimized.

@TomFischer

TomFischer Aug 28, 2018

Member

You could update the offset before the for-loop: offset += n_local_regular_elements; and write here and in line 597 only offset + e.

bulk_element_ids[offset + n_local_regular_elements +
e] = global_to_local
[bulk_element_ids[offset + n_local_regular_elements + e]];
}

This comment has been minimized.

@TomFischer

TomFischer Aug 28, 2018

Member

The loops for the regular and the ghost elements look very similar. Maybe a lambda can be called twice?

@endJunction endJunction force-pushed the endJunction:PartitionBoundaryMeshesProperties branch 2 times, most recently from 19e9f26 to bbb4dfb Aug 31, 2018

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Sep 10, 2018

@wenqing Maybe you want to have a look before I merge it (let's say on Wednesday).

@wenqing
Copy link
Member

wenqing left a comment

👍

@endJunction endJunction force-pushed the endJunction:PartitionBoundaryMeshesProperties branch from bbb4dfb to 22548c4 Sep 10, 2018

@endJunction endJunction merged commit 44bc9dd into ufz:master Sep 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:PartitionBoundaryMeshesProperties branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.