Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc for OgsTester #2257

Merged
merged 7 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@endJunction
Copy link
Member

endJunction commented Nov 6, 2018

Extracted from OgsTester PR.

Few changes found during the OgsTester implementation. The extracted function in the VtuInterface is reused in OgsTester PR.

@chleh
Copy link
Collaborator

chleh left a comment

👍 after modified tests actually run.

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Nov 6, 2018

Hmmm.... Something is wrong there. Thinking aloud....
Of the three modified test the axisymmetric_pipe.prj is executed normally with Eigen, and it does not matter if the solid_density is there or not. But the hollow_sphere.prj (which is enabled for LIS only) does not run w/o solid_density.

Update: Got it now. There is another axisymmetric_pipe.prj

@endJunction endJunction force-pushed the endJunction:MiscForOgsTester branch from 75ba75b to 7dd9334 Nov 6, 2018

@bilke

bilke approved these changes Nov 6, 2018

@wenqing

wenqing approved these changes Nov 6, 2018

endJunction added some commits Oct 5, 2018

[T] M/SD; Cleanup duplicate axisymmetric_pipe.
Same test is in PressureBC/ directory; Moved reference result
and removed the duplicate prj/gml/vtu.
[T] M/SD; Cleanup almost duplicate axisymm. sphere
Almost the same test in the PressureBC/ with different forces applied.
Move everything to PressureBC.
Vectorize sigma in reference result.
[T] SD/hollow sphere. Changes solver tols.
Vectorize sigma in reference file.
Enable for Eigen builds too, update tolerance for sigma.

@endJunction endJunction force-pushed the endJunction:MiscForOgsTester branch from 7dd9334 to 517c317 Nov 6, 2018

@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Nov 6, 2018

hollow_sphere test runs successfully with Eigen using CG/Diagonal linear solver.
Now all of the changed tests are Eigen enabled and do run (on my machine at least ;).

@bilke singularity1 hit a singularity ;(

@endJunction endJunction merged commit c542e53 into ufz:master Nov 6, 2018

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:MiscForOgsTester branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.