BHE_1U flow properties update and bugfixes. #2271
Conversation
endJunction
force-pushed
the
BHE1U_flow_properties
branch
from
225e530
to
a8ba7d9
Compare
|
@endJunction I'd love to. Thank you very much. |
endJunction
changed the title
|
@endJunction Could you please move the implementation of the constructor and other functions in "CreateFlowAndTemperatureControl.h" to the cpp file? In the case of the CXA/CXC or 2U BHE, we also need to call the function named "createFlowAndTemperatureControl", and this will cause an error of multiple definition when compiling. Besides, we also need to enrich flow and temperature boundary conditions including coupled with heat pump. I am not sure if my understanding is right, but please consider it. |
|
@ChaofanChen CreateFlowAndTemperatureControl.h is not part of this PR. Please open another PR. |
| double outsideArea() const | ||
| { | ||
| constexpr double pi = boost::math::constants::pi<double>(); | ||
| double const d = diameter + wall_thickness; |
There was a problem hiding this comment.
Looks good. After '2 * ...' ⏩
When @ChaofanChen has reviewed then the PR can be merged.
| double outsideArea() const | ||
| { | ||
| constexpr double pi = boost::math::constants::pi<double>(); | ||
| double const d = diameter + wall_thickness; |
There was a problem hiding this comment.
d = diameter + wall_thickness * 2 ?
Eliminates code duplication in future 2U implementation.
This is used in the CXA/CXC implementations.
The result is the same, but semantically it was in wrong order.
endJunction
force-pushed
the
BHE1U_flow_properties
branch
from
6973ed7
to
103b07c
Compare
|
OpenGeoSys development has been moved to GitLab. |
Use already extracted code. This prevents code duplication for 2U and the CXA/CXC implementations.
@ChaofanChen Could you please review this?