SmallDeformation nonlocal #2294

endJunction · 2018-12-11T09:48:21Z

Don't worry, most changes are the test cases, the code is around 2kLOC.

Based on Francesco's paper (published, not yet available online) "Experimental characterization and numerical modelling of fracture processes in granite".

Main difference to the SmallDeformation process is the additional, so called non-local integration loop.

endJunction · 2018-12-11T14:12:17Z

@wenqing @TomFischer @renchao-lu Let's meet on Friday at 11 for discussion.

wenqing

Looks good except some small stuffs.

wenqing · 2018-12-17T11:26:05Z

MaterialLib/SolidModels/Ehlers.cpp

@@ -53,6 +53,19 @@ template <int DisplacementDim>
 MathLib::KelvinVector::KelvinMatrixType<DisplacementDim> sOdotS(
    MathLib::KelvinVector::KelvinVectorType<DisplacementDim> const& v);

+template <int DisplacementDim>
+MathLib::KelvinVector::KelvinMatrixType<DisplacementDim>
+elasticTangentStiffness(double const K, double const G)


There is a similar function in MaterialLib/SolidModels/LinearElasticIsotropic.cpp, and it is called getElasticTensor. It might be good to use the same name.

Good point. I chose the version with the first Lame parameter instead of the bulk modulus.

wenqing · 2018-12-17T11:30:54Z

ProcessLib/SmallDeformationNonlocal/CreateSmallDeformationNonlocalProcess.cpp

+        config.getConfigParameter<double>("internal_length");
+
+    SmallDeformationNonlocalProcessData<DisplacementDim> process_data{
+        materialIDs(mesh),     std::move(solid_constitutive_relations),


Is this line formatted by using clang-format?

Yes. Table alignment.

wenqing · 2018-12-17T11:35:00Z

ProcessLib/SmallDeformationNonlocal/Damage.h

+{
+    double const damage = (1 - beta_d) * (1 - std::exp(-kappa_d / alpha_d));
+
+    if (damage < 0. || damage > 1.)


Is it necessary that let damage = damage < 0. ? 0 : damage and damage = damage > 1. ? 1 : damage?

Put an assert there and check for half open interval [0, 1).

wenqing · 2018-12-17T11:43:33Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalFEM.h

+            // Compute sigma_eff from damage total stress sigma
+            using KelvinVectorType = typename BMatricesType::KelvinVectorType;
+            KelvinVectorType const sigma_eff_prev =
+                sigma_prev / (1. - damage_prev);


Is there a possibility that damage_prev = 1.0?

Damage can not be 1, see calculateDamage(). Comment added.

TomFischer · 2018-12-18T11:49:28Z

MathLib/KelvinVector-impl.h

@@ -18,7 +18,7 @@ double Invariants<KelvinVectorSize>::equivalentStress(
    Eigen::Matrix<double, KelvinVectorSize, 1> const& deviatoric_v)
 {
    assert(std::abs(trace(deviatoric_v)) <=
-           5e-14 * diagonal(deviatoric_v).norm());
+           2e-13 * diagonal(deviatoric_v).norm());


How did you find these magic number?

reduce it until it works ;)

TomFischer · 2018-12-18T11:55:33Z

ProcessLib/SmallDeformationNonlocal/CreateSmallDeformationNonlocalProcess.cpp

+        {//! \ogs_file_param_special{prj__processes__process__SMALL_DEFORMATION_NONLOCAL__process_variables__process_variable}
+         "process_variable"});
+
+    DBUG("Associate displacement with process variable \'%s\'.",


Why is the symbol ' escaped?

Just to be on the safe side ;)
Removing.

TomFischer · 2018-12-18T11:58:48Z

ProcessLib/SmallDeformationNonlocal/Damage.h

+    if (damage < 0. || damage >= 1.)
+    {
+        ERR("Damage value %g outside of [0,1) interval.", damage);
+        assert(false && "damage not in [0,1) interval.");


Why not OGS_FATAL?

TomFischer · 2018-12-18T12:08:32Z

ProcessLib/SmallDeformationNonlocal/IntegrationPointData.h

+    typename BMatricesType::KelvinVectorType eps, eps_prev;
+    double free_energy_density = 0;
+    double damage = 0;       ///< isotropic damage
+    double damage_prev = 0;  ///< \copydoc damage


Is the '\copydoc' intended?

TomFischer · 2018-12-18T12:14:30Z

ProcessLib/SmallDeformationNonlocal/LocalAssemblerInterface.h

+        NumLib::LocalToGlobalIndexMap const& /*dof_table*/,
+        std::vector<double>& cache) const = 0;
+
+    // TODO move to NumLib::ExtrapolatableElement


Is this TODO easy to fulfil?

No. Is related to output and the TODO is in all processes.

TomFischer · 2018-12-18T12:20:35Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalFEM.h

+{
+namespace SmallDeformationNonlocal
+{
+/// Used by for extrapolation of the integration point values. It is ordered


Either 'by' or 'for'.

TomFischer · 2018-12-18T12:23:32Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalFEM.h

+        if (ehlers_solid_material == nullptr)
+        {
+            OGS_FATAL(
+                "The SmallDeformationNonlocalLocal supports only Ehlers "


IMHO the word 'process' is missing.

TomFischer · 2018-12-18T12:27:42Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalFEM.h

+                _element.getID());
+        }
+
+        if (name == "sigma_ip")


This string comparison is done for every integration point. Is this computational expensive? Would an enum an option?

Enum is not an option because each process might call this differently. The function call (and so the comparison) happens once for each element when setting initial conditions.

TomFischer · 2018-12-19T09:37:52Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalFEM.h

+            BMatricesType, ShapeMatricesType, DisplacementDim>>>
+        _ip_data;
+
+    IntegrationMethod _integration_method;


Why not const?

TomFischer · 2018-12-19T11:17:51Z

ProcessLib/SmallDeformationNonlocal/SmallDeformationNonlocalProcess.h

+private:
+    int const _integration_order;
+    std::function<std::vector<std::vector<double>>()> _callback;
+};


Please move the writer to separate files.

Moved into single separate file.

The different tangent types used for the tangent stiffness computation.

These tests are failing on testing machines.

Same function is used in Ehlers and in the LinearElasticIsotropic.

endJunction · 2018-12-19T18:05:08Z

@fparisio Once the paper is published we need to add the corresponding test descriptions to the web benchmark documentation page.

ogsbot · 2020-06-19T12:56:36Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

endJunction added the WIP 🏗️ label Dec 11, 2018

endJunction force-pushed the SDNonlocal branch 4 times, most recently from 3e82a00 to 282c727 Compare December 12, 2018 17:46

endJunction added please review and removed WIP 🏗️ labels Dec 13, 2018

endJunction force-pushed the SDNonlocal branch from 282c727 to 764c8b8 Compare December 13, 2018 14:37

wenqing approved these changes Dec 17, 2018

View reviewed changes

endJunction force-pushed the SDNonlocal branch from 764c8b8 to 555b759 Compare December 18, 2018 11:15

TomFischer reviewed Dec 18, 2018

View reviewed changes

endJunction force-pushed the SDNonlocal branch from 555b759 to edc7f83 Compare December 18, 2018 12:44

TomFischer reviewed Dec 19, 2018

View reviewed changes

endJunction and others added 8 commits December 19, 2018 17:36

[PL] Implementation of SmallDeformationNonlocal.

a0fe592

[PL] SDN; Damage calculations.

666d456

[MatL] Ehlers; Add Elastic and PlasticDamageSecant

bdd4142

The different tangent types used for the tangent stiffness computation.

[T] Ehlers; Add tangent type option to the tests.

25cd32d

[T] Add SmallDeformationNonlocal tests.

3d0705a

[doc] Copy from SD. Document new tags.

781a84b

[T] SDN; Add test_definition to project files.

cc8bb27

[T] SDN; Use OgsTest() calls for ctests.

9a6adb4

endJunction added 4 commits December 19, 2018 17:36

[T] Relax tolerances for sigma.

ae8d018

These tests are failing on testing machines.

[MaL] Specialize for dynamic Kelvin to tensor conv

d4b703e

[MaL] KelvinVector; Relax deviatoric assertion.

5744cd1

[MatL] Solids; Extract elasticTangentStiffness().

ec1e0bd

Same function is used in Ehlers and in the LinearElasticIsotropic.

endJunction force-pushed the SDNonlocal branch from edc7f83 to ec1e0bd Compare December 19, 2018 16:36

endJunction removed the please review label Dec 19, 2018

endJunction merged commit 0fba06a into ufz:master Dec 19, 2018

endJunction deleted the SDNonlocal branch December 19, 2018 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SmallDeformation nonlocal #2294

SmallDeformation nonlocal #2294

endJunction commented Dec 11, 2018 •

edited

Loading

endJunction commented Dec 11, 2018

wenqing left a comment

wenqing Dec 17, 2018

endJunction Dec 18, 2018

wenqing Dec 17, 2018

endJunction Dec 18, 2018

wenqing Dec 17, 2018

endJunction Dec 18, 2018

wenqing Dec 17, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 18, 2018

endJunction Dec 18, 2018

TomFischer Dec 19, 2018

endJunction Dec 19, 2018

TomFischer Dec 19, 2018

endJunction Dec 19, 2018

endJunction commented Dec 19, 2018

ogsbot commented Jun 19, 2020

SmallDeformation nonlocal #2294

SmallDeformation nonlocal #2294

Conversation

endJunction commented Dec 11, 2018 • edited Loading

endJunction commented Dec 11, 2018

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction commented Dec 19, 2018

ogsbot commented Jun 19, 2020

endJunction commented Dec 11, 2018 •

edited

Loading