Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mohr-Coulomb-Abbo-Sloan MFront solid material model. #2634

Merged
merged 15 commits into from Aug 30, 2019

Conversation

@endJunction
Copy link
Member

endJunction commented Aug 28, 2019

The material model (and its orthotropic version) with different tests: MTests, unit-tests, ctests.

  1. Feature description was added to the changelog

  2. Tests covering your feature were added?

  3. Any new feature or behavior change was documented? Maybe later.

@endJunction endJunction force-pushed the endJunction:MohrCoulombAbboSloan branch 5 times, most recently from 419556e to e57be9d Aug 29, 2019
@TomFischer

This comment has been minimized.

Copy link
Member

TomFischer commented Aug 30, 2019

Under which license and copyright are the mfront and python files?

@endJunction endJunction force-pushed the endJunction:MohrCoulombAbboSloan branch from e57be9d to 299383a Aug 30, 2019
@endJunction

This comment has been minimized.

Copy link
Member Author

endJunction commented Aug 30, 2019

@TomFischer The python files are "ours" as well as the MohrCoulombAbboSloan mfront. Adding license to mfront files. Keep py files w/o license as e.g. the gml files.

Some other mfront files need clarification. I'll take care of the correct licenses.

Copy link
Member

TomFischer left a comment

I don't understand that much of the PR. When the license/copyright has been claryfied and the tests are green:

@endJunction endJunction force-pushed the endJunction:MohrCoulombAbboSloan branch from 299383a to c6a144b Aug 30, 2019
@endJunction endJunction merged commit a2f0a23 into ufz:master Aug 30, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190830.16 succeeded
Details
@endJunction endJunction deleted the endJunction:MohrCoulombAbboSloan branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.