Functionalyties for tets in MapBulkElementPoint.cpp #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
reviewed
Sep 12, 2019
| @@ -117,6 +138,11 @@ MathLib::Point3d getBulkElementPoint(MeshLib::Mesh const& mesh, | |||
| *dynamic_cast<MeshLib::Prism const*>(element)); | |||
| return getBulkElementPoint(prism, bulk_face_id, wp); | |||
| } | |||
| if (element->getCellType() == MeshLib::CellType::TET4) | |||
| { | |||
| MeshLib::Tet const& tet(*dynamic_cast<MeshLib::Tet const*>(element)); | |||
There was a problem hiding this comment.
Suggested change
| MeshLib::Tet const& tet(*dynamic_cast<MeshLib::Tet const*>(element)); | |
| MeshLib::Tet const& tet = *static_cast<MeshLib::Tet const*>(element); |
Type is already checked.
endJunction
approved these changes
Sep 12, 2019
jbathmann
force-pushed
the
tet_to_bulk_element_mapping
branch
2 times, most recently
from
1f1718c
to
9345bbf
Compare
jbathmann
force-pushed
the
tet_to_bulk_element_mapping
branch
from
7378f39
to
4eb2165
Compare
|
Changelog updated. |
jbathmann
force-pushed
the
tet_to_bulk_element_mapping
branch
from
4eb2165
to
0c4f7b1
Compare
added 2 commits
September 13, 2019 12:34
The test also tests the openflowboundary for the non advective implementation of hc process --amend
jbathmann
force-pushed
the
tet_to_bulk_element_mapping
branch
from
0c4f7b1
to
ddb4fb6
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of coordinate-mapping derived by @TomFischer for tetrahedrons.
Test for this functionality included in PR