Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionalyties for tets in MapBulkElementPoint.cpp #2662

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@jbathmann
Copy link
Contributor

jbathmann commented Sep 12, 2019

Implementation of coordinate-mapping derived by @TomFischer for tetrahedrons.
Test for this functionality included in PR

@@ -117,6 +138,11 @@ MathLib::Point3d getBulkElementPoint(MeshLib::Mesh const& mesh,
*dynamic_cast<MeshLib::Prism const*>(element));
return getBulkElementPoint(prism, bulk_face_id, wp);
}
if (element->getCellType() == MeshLib::CellType::TET4)
{
MeshLib::Tet const& tet(*dynamic_cast<MeshLib::Tet const*>(element));

This comment has been minimized.

Copy link
@endJunction

endJunction Sep 12, 2019

Member
Suggested change
MeshLib::Tet const& tet(*dynamic_cast<MeshLib::Tet const*>(element));
MeshLib::Tet const& tet = *static_cast<MeshLib::Tet const*>(element);

Type is already checked.

This comment has been minimized.

Copy link
@jbathmann

jbathmann Sep 12, 2019

Author Contributor

Changed for all cases.

Copy link
Member

endJunction left a comment

Looks good!
Update the changelog,

@jbathmann jbathmann force-pushed the jbathmann:tet_to_bulk_element_mapping branch 2 times, most recently from 1f1718c to 9345bbf Sep 12, 2019
@jbathmann jbathmann force-pushed the jbathmann:tet_to_bulk_element_mapping branch from 7378f39 to 4eb2165 Sep 13, 2019
@jbathmann

This comment has been minimized.

Copy link
Contributor Author

jbathmann commented Sep 13, 2019

Changelog updated.

@jbathmann jbathmann force-pushed the jbathmann:tet_to_bulk_element_mapping branch from 4eb2165 to 0c4f7b1 Sep 13, 2019
jbathmann added 2 commits Sep 12, 2019
The test also tests the openflowboundary for the non advective implementation of hc process

--amend
@jbathmann jbathmann force-pushed the jbathmann:tet_to_bulk_element_mapping branch from 0c4f7b1 to ddb4fb6 Sep 13, 2019
@TomFischer TomFischer merged commit 8dc50b3 into ufz:master Sep 13, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190913.8 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.