Benchmark for PermeabilityMohrCoulombFailureIndexModel #2995

wenqing · 2020-06-09T17:28:51Z

as titled. Temporally, this PR contains the commits of PR # #2989.

Feature description was added to the changelog Not yet.
Tests covering your feature were added? Yes.
Any new feature or behavior change was documented? Not yet.

ProcessLib/RichardsMechanics/RichardsMechanicsFEM.h

wenqing · 2020-06-10T15:50:33Z

HM has cell wise permeability output. The following figure shows the permeability output of this test

endJunction · 2020-06-18T09:06:15Z

ProcessLib/HydroMechanics/HydroMechanicsFEM-impl.h

+        // TODO (wenqing): get a model type, and use it to avoid the following
+        // assignment if no stress dependent permeability model is used.


Just to get your idea, how would you do it? How would you find out if an arbitrary permeability model is stress dependent?

Can we add a member to Property to return its type?

I don't quite get it. Would you elaborate?
So there will be a member in the Property class, let's say x(). It would return what?
How would you use the result here to find out if an arbitrary permeability model is stress dependent?

For example:

virtual bool Property::hasStressVariable() const {return false;} bool PermeabilityMohrCoulombFailureIndexModel::hasStressVariable() const override {return true;}

This does not scale well, because for every new variable like stress etc. the Property interface has to be updated. So, then one would add a new enum value, two string conversions (back and forth), and additionally a test function and an if-condition to every process which is going to use it. Also how do you find out for MFront materials if there is dependency on a particular variable?
I'd drop the comment. Keeping things simple is an advantage. How much time would it save for each assembly?

The major computation is a two vector (with a size of 4 or 6) addition at the integration points. I have not compared the time increases in the local assembler for large problems. I think, it may increase the local assembly time for the maximum magnitude of 1%.

An enum type might be good. This would be put to another PR if an if-condition for passing stress to Property is needed.

endJunction · 2020-06-18T09:09:11Z

ProcessLib/HydroMechanics/HydroMechanicsFEM-impl.h

+                static_cast<SymmetricTensor>(_ip_data[ip].sigma_eff -
+                                             alpha * identity2 * p_int_pt)));


Why the cast?
The type of the sigma_eff*alpha*I*p is KelvinVector. Conversion to SymmetricTensor requires sqrt(2) multiplications.

Why the cast?

If only sigma_eff, no cast is needed. identity2 needs a cast.

The type of the sigma_eff*alpha*I*p is KelvinVector. Conversion to SymmetricTensor requires sqrt(2) multiplications.

Please take a look at my new PR, #3010, about kelvinVectorToSymmetricTensor. I assumed that function handles that multiplier correctly.

As discussed in the closed PR #3010, kelvinVectorToSymmetricTensor converts the Kelvin stress to conventional stress correctly.

The kelvinVectorToSymmetricTensor handles the sqrt(2) multiplier correctly. static_cast is wrong way to bend the types. Use eval.

use .eval().

endJunction · 2020-06-18T09:27:05Z

Tests/Data/HydroMechanics/FailureIndexDependentPermeability/quad_with_half_hole.prj

+                        <property>
+                            <name>density</name>
+                            <type>Constant</type>
+                            <value>1</value>


Density in the documentation is 1000. And also other values are not the same. This should be fixed.

Corrected. Since the gravity term in the Darcy is omitted, it only makes a tiny change in permeability and stresses, which cannot be distinguished in the contour plot.

Did you check all of the other values?

what about solid density?

Changed to 2.65e+3. I see that you means the input parameters.

wenqing · 2020-06-18T13:29:32Z

web/content/docs/benchmarks/hydro-mechanics/PermeabilityMohrCoulombFailureIndexModel.pandoc

+  please read [the PDF](../PermeabilityMohrCoulombFailureIndexModel.pdf).
+
+For a full document of the failure index dependent
+ permeability model, benchmark and its the implementation in ogs6, etc.,


@OlafKolditz
The link to the document on Overleaf was added. Please see Preview

wenqing · 2020-06-18T14:27:02Z

@endJunction: @nagelt asked you a question in his comment about the comment by @OlafKolditz about use Overleaf in web/doc. These comments was detached due to the update of this PR.

endJunction

The documentation and the project file should describe exactly same problems.

wenqing · 2020-06-19T08:55:50Z

The documentation and the project file should describe exactly same problems.

Changes in doc:

added parameters for the permeability model,
added the description of the initial conditions of pore pressure and stress.
corrected a typo in row 2 of Table 2, tau_x=-15 MPa instead of \tau_y

Changes in prj:
porosity -> 0.15. The ref. result file and the figures for the doc. were updated accordingly.

…ability model for EDZ

ogsbot · 2020-06-19T13:24:57Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

This issue / pull request was open before the GitLab migration.

wenqing added WIP 🏗️ don't review labels Jun 9, 2020

endJunction reviewed Jun 9, 2020

View reviewed changes

ProcessLib/RichardsMechanics/RichardsMechanicsFEM.h Outdated Show resolved Hide resolved

wenqing force-pushed the apply_permeability_stress branch 3 times, most recently from 05f61a5 to 6689da3 Compare June 10, 2020 15:45

wenqing force-pushed the apply_permeability_stress branch 10 times, most recently from 957ee91 to 5668d82 Compare June 16, 2020 08:59

wenqing removed WIP 🏗️ don't review labels Jun 16, 2020

wenqing force-pushed the apply_permeability_stress branch 5 times, most recently from 8ed46ce to 1fa184f Compare June 18, 2020 07:47

endJunction reviewed Jun 18, 2020

View reviewed changes

wenqing force-pushed the apply_permeability_stress branch 2 times, most recently from a6396c3 to 9d676e4 Compare June 18, 2020 12:19

wenqing mentioned this pull request Jun 18, 2020

[Math/KelvinVector] Added an argument of double factor to kelvinVectorToSymmetricTensor #3010

Closed

wenqing force-pushed the apply_permeability_stress branch from 9d676e4 to 100950f Compare June 18, 2020 12:37

wenqing added 3 commits June 18, 2020 14:56

[THM] use stress dependent permeability

22f1b66

[RichardsMechanics] use stress dependent permeability

625d0e2

[HydroMechanics] use stress dependent permeability

20cb670

wenqing force-pushed the apply_permeability_stress branch from 100950f to 4b3bd85 Compare June 18, 2020 13:11

wenqing commented Jun 18, 2020

View reviewed changes

wenqing force-pushed the apply_permeability_stress branch from 4b3bd85 to b7a1aa3 Compare June 18, 2020 14:49

endJunction requested changes Jun 18, 2020

View reviewed changes

wenqing force-pushed the apply_permeability_stress branch 2 times, most recently from 35ff8b4 to 90bd0a8 Compare June 19, 2020 08:51

wenqing added 2 commits June 19, 2020 13:06

[Ctest] added a HM test for PermeabilityMohrCoulombFailureIndexModel

07c8824

[benchmark#doc] Added a description about the benchmark for the perme…

5ef3c13

…ability model for EDZ

wenqing force-pushed the apply_permeability_stress branch from 90bd0a8 to 5ef3c13 Compare June 19, 2020 11:10

ogsbot closed this Jun 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Benchmark for PermeabilityMohrCoulombFailureIndexModel #2995

Benchmark for PermeabilityMohrCoulombFailureIndexModel #2995

wenqing commented Jun 9, 2020 •

edited

wenqing commented Jun 10, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020 •

edited

wenqing Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020

endJunction Jun 18, 2020

wenqing Jun 18, 2020 •

edited

wenqing Jun 18, 2020 •

edited

wenqing commented Jun 18, 2020

endJunction left a comment

wenqing commented Jun 19, 2020 •

edited

ogsbot commented Jun 19, 2020

		// TODO (wenqing): get a model type, and use it to avoid the following
		// assignment if no stress dependent permeability model is used.

		static_cast<SymmetricTensor>(_ip_data[ip].sigma_eff -
		alpha * identity2 * p_int_pt)));

Benchmark for PermeabilityMohrCoulombFailureIndexModel #2995

Benchmark for PermeabilityMohrCoulombFailureIndexModel #2995

Conversation

wenqing commented Jun 9, 2020 • edited

wenqing commented Jun 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction Jun 18, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wenqing Jun 18, 2020 • edited

Choose a reason for hiding this comment

wenqing Jun 18, 2020 • edited

Choose a reason for hiding this comment

wenqing commented Jun 18, 2020

endJunction left a comment

Choose a reason for hiding this comment

wenqing commented Jun 19, 2020 • edited

ogsbot commented Jun 19, 2020

wenqing commented Jun 9, 2020 •

edited

endJunction Jun 18, 2020 •

edited

wenqing Jun 18, 2020 •

edited

wenqing Jun 18, 2020 •

edited

wenqing commented Jun 19, 2020 •

edited