ConfigTree -- Follow-Up PR #955
Conversation
| _tree = other._tree; | ||
| other._tree = nullptr; | ||
| _path = other._path; | ||
| _visited_params = std::move(other._visited_params); |
There was a problem hiding this comment.
Why are the other variables copied and not moved?
There was a problem hiding this comment.
I improved the move assignment quite a bit.
|
👍 |
const + mutable enable use as temporary variables move assignment complements move construction
chleh
force-pushed
the
config-tree-fup
branch
from
4c2b1b6
to
ca86699
Compare
|
Due to #951 there was a non-trivial rebase necessary. You might want to recheck ProcessLib/Process and ProcessLib/GWFlowProcess. The last two commits address comments by Dima. The third last commit improves move-assignment and adds a test for that. |
|
⏩ |
|
Just found a bug for PETSC. Resolved in the last commit. I think that will go without further review. But there really should be a working PETSC build on Jenkins... |
|
Build finished. No test results found. |
|
Build finished. No test results found. |
|
Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/992/ |
|
@chleh Go ahead. We will fix PETSc tests and possible bugs in the next few days. |
chleh
force-pushed
the
config-tree-fup
branch
from
fd24908
to
0b01418
Compare
|
OpenGeoSys development has been moved to GitLab. |
This PR completes the transition to the new ConfigTree for project files.
Changes:
mutableand all methodsconstin order to be able to pass temporary instances directly to function callsTODO (subsequent PR):