Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail.create really has to render the template, even with empty context! #84

Closed
tuky opened this issue Oct 17, 2014 · 3 comments
Closed

mail.create really has to render the template, even with empty context! #84

tuky opened this issue Oct 17, 2014 · 3 comments

Comments

@tuky
Copy link
Contributor

tuky commented Oct 17, 2014

Having no context does not mean, you do not want the template to be rendered. Just think of so many use cases:

  • translation
  • {% current_time "%Y-%m-%d %I:%M %p" %}

Thx!
@selwin
Copy link
Collaborator

selwin commented Oct 18, 2014

Agreed, I would welcome a PR to fix this issue :)

@tuky tuky mentioned this issue Oct 18, 2014
Merged
@tuky
Copy link
Contributor Author

tuky commented Oct 18, 2014

Great, here we go.

@selwin
Copy link
Collaborator

selwin commented Oct 25, 2014

Fixed in #85

@selwin selwin closed this as completed Oct 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@selwin @tuky