Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix render cycle bug (resize-handler) & bump versions #14

Merged
merged 8 commits into from Jul 28, 2023

Conversation

wridgeu
Copy link
Contributor

@wridgeu wridgeu commented Jul 27, 2023

Fixes #13 and continues to work not only in 1.116.0 but also the previous 1.86.3 version.

Additionally it bumps the node versions used in the gh workflow (14 is quite old now).

gregorwolf and others added 5 commits July 27, 2023 19:15
…endering cycle

the control must be 'completed' for the renderer manager to properly determine & resolve parents for focus hanldling, resizing ...
@wridgeu wridgeu requested a review from vobu July 27, 2023 21:45
@wridgeu
Copy link
Contributor Author

wridgeu commented Jul 27, 2023

1155eab: Not only is the bumping at fault, but I think using the global cli install would default to the latest anyway.

UI5 CLI 3.X.X engines definition

Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vobu vobu merged commit 2e6ad08 into ui5-community:main Jul 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants