Issue "Cannot read properties of undefined (reading 'id') at ResizeHandler.attachListener" with current OpenUI5 / SAPUI5 Version

[gregorwolf]

We use this control in our app that is deployed to the SAP Build Work Zone. It's currently using SAPUI5 Version 1.116.0. There I get this error in the console:

Uncaught TypeError: Cannot read properties of undefined (reading 'id')
    at ResizeHandler.attachListener (ResizeHandler.js?eval:119:19)
    at ResizeHandler.register (ResizeHandler.js?eval:241:25)
    at constructor.onAfterRendering (ScrollEnablement.js:746:46)
    at each (Element.js?eval:349:31)
    at Element._handleEvent (Element.js?eval:362:3)
    at finalizeRendering (RenderManager.js?eval:1262:16)
    at flushInternal (RenderManager.js?eval:1347:4)
    at RenderManager.render (RenderManager.js?eval:1497:4)
    at UIArea.rerender (UIArea.js?eval:651:22)
    at _renderPendingUIUpdates (Rendering.js?eval:100:40)

I've created the branch bug/resize-handler where this issue can be replicated.

[wridgeu]

Hey @gregorwolf

interesting! I had a look and dug around a bit. I figured out that the error only occurred in the second use-case, using the fromFile option. That might very well be related to the way it was previously implemented or rather fixed in #5 and the way the render cycles worked or handled the rendering itself.

Previously the control wasn't really "finished", no closing 'div'-tag was added but it still worked. It was due to the way the rendering happened/got triggered and the rerender then took care of it and replaced/overwrote the control accordingly (crude, rough explanation for what I have in my mind right now => basically the 2nd render/rerender/cycle ... would've closed it when adding the content).

Now that doesn't seem to work anymore as it completely crashes when the control isn't properly closed and has issues in finding the parents of the control for resize & focus handling. There is also a warning displayed after your error, saying it cannot determine the DOM location for this custom control:

I tested a simple adjustment here fix/resize-handler-bug.

Take it with a grain of salt though, I'm not that good with words here and definitely don't have a perfect mental model of all that happens in the rendering of UI5, but I try. ^^

Were there other scenarios that didn't work?

BR,
Marco :)

[gregorwolf]

Hi @wridgeu,

thank you for the correction. In the browser the error is gone and the markdown file displayed again. I would say get the PR ready.

CU
Gregor

[wridgeu]

Oh, awesome. :)

I'll simply use the fix and include your version bumps & everything in the PR (not sure if the .nvmrc is necessary though?) and have Volker give it another look.

BR
Marco