Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth to routes #492

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Add auth to routes #492

merged 6 commits into from
Feb 16, 2021

Conversation

d-sooter
Copy link
Contributor

Add auth support.

The user can pass the authenticationMethod via the options
and the authentication method defined in the routes is respected and used

Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small change necessary

@@ -52,6 +52,7 @@ server:
- name: ui5-middleware-cfdestination
afterMiddleware: compression
configuration:
authenticationMethod: none # none or route default is none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma + quotes missing (pedantry, i know 😛 )
# "none" || "route", default: "none"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vobu vobu merged commit ef735c4 into ui5-community:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants