lightbox fix - display images which has query strings in the url #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UIKit version 2 has been moved to another branch: https://github.com/uikit/uikit/tree/v2/develop Please update the target branch of your pull request. |
|
@philoest UIkit 3 beta.v30 still has this issue, should this PR be merge into the V3 too? |
|
Is there any update on this? Running into the same thing with signed urls from amazon s3.. |
|
You can simply add type="image" to force an image. |
|
Resolved with cdaeb64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When images have timestamps on them the Lightbox will not open them ...
<a href="/images/gallery/image-1.jpg?57ed752b" data-uk-lightbox="{group:'gallery'}" title="Title"> <img src="/images/gallery/image-1-thumb.jpg?57ed77ee" alt="Title"> </a>Fixed it.