Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite JshintCommand entirely #56

Merged
merged 2 commits into from
Sep 6, 2013
Merged

Rewrite JshintCommand entirely #56

merged 2 commits into from
Sep 6, 2013

Conversation

FichteFoll
Copy link
Contributor

This version does not require to change the currently active build system since it calls the build by itself. Changing the active build system is highly discouraged since this is something the user must change everytime after he uses this command if he uses a "real" build system for this file/project.

I wrote this for a user in IRC which was having the above mentioned issue so I personally didn't test it but according to him it worked (on OSX).

This version does not require to change the currently active build system since it calls the build by itself.
@uipoet
Copy link
Owner

uipoet commented May 3, 2013

This is a very interesting change. I would like to decouple the dependency on building, however there would be side-effects such as losing on save building via other plugins. Perhaps with adding the ability to the plugin itself with a configurable option we may have both. Thanks for this!

@FichteFoll
Copy link
Contributor Author

The main issue here is overriding the default (or selected) build system for your file. As such, if you want to build on save then it should probably be the build system you selected. If you want to automatically run jshint on save, that's no problem because you can select the jshint build then (or hope that it's selected with "Automatic").

Furthermore, you could even listen to "on_post_save" messages and run jshint above that, much like SublimeLinter does, except with a quick panel instead of an output panel. With an option ofc.

@FichteFoll
Copy link
Contributor Author

push

uipoet added a commit that referenced this pull request Sep 6, 2013
JSHint decoupled from default build system.
@uipoet uipoet merged commit 90df196 into uipoet:master Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants