Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Missing quotes for file path (with spaces) #9

Open
fritx opened this issue Nov 5, 2015 · 3 comments
Open

[bug] Missing quotes for file path (with spaces) #9

fritx opened this issue Nov 5, 2015 · 3 comments

Comments

@fritx
Copy link
Collaborator

fritx commented Nov 5, 2015

The cmd line seems to break if a path like E:\Program Files\ passed in.
fritx added a commit to fritx/node-screencapture that referenced this issue Nov 5, 2015
@fritx
Using quotes for file path in cmd call, fix uiur#9
1c93c53 
uiur#9
@uiur
Copy link
Owner

uiur commented May 8, 2016 •
edited
Loading

@fritx Do you still have any motivation for this?

I have little time to maintain this repo now. So I would like to add you as a collaborator if you want.

@fritx
Copy link
Collaborator Author

fritx commented May 9, 2016

@uiureo yes, no problem!
Our team has been using this library for screencapture in our company IM, which has thousands of internal stuff as users.
And we have our own fork.
This lib is awesome 👍

@uiur
Copy link
Owner

uiur commented May 11, 2016

@fritx thanks! added you as a collaborator 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uiur @fritx