Caching the local timezone #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW We (ZR) aren't using this module, but I am willing to accept pull requests that improve things. If someone in the future wants me to accept a pr that fixes the same thing as this PR, please migrate from DateTime to parsed epochs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was profiling our application that's using DynamoDB, and the creation of the DateTime::TimeZone objects in _init_security_token turns out to be very expensive. This change would potentially cause problems on systems where the local timezone changes, so definitely let me know if you have any concerns.
This is a pretty major performance improvement in my application, so if you're hesitant to potentially break people on systems with changing local timezones, maybe I could make this a configuration option instead of caching by default?