Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis.multi should return Redis #64

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Redis.multi should return Redis #64

merged 2 commits into from
Aug 8, 2019

Conversation

Leneshka-jb
Copy link
Contributor

Redis.multi should return Redis

@ukko ukko merged commit b858c70 into ukko:master Aug 8, 2019
@Leneshka-jb
Copy link
Contributor Author

Leneshka-jb commented Aug 8, 2019 •
edited

Thank you so much! Could you please add this change and #62 to JetBrains/phpstorm-stubs#643? I've run it against our test set of frameworks, no major regressions detected, so I could finally merge that request Sorry, merged that request too early, so added those changes myself

@Leneshka-jb Leneshka-jb deleted the multi branch August 8, 2019 15:41
@ukko
Copy link
Owner

ukko commented Aug 9, 2019

Thank you, @Leneshka-jb )

I will make new PR to JetBrains/phpstorm-stubs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Leneshka-jb @ukko