-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::allocator<T>: use of 'construct' and 'destroy' deprecated since C++17 #532
Comments
If we merge #514 would you be able to add a job for C++20 compatibility given our infrastructure? |
your patch also seems trivial to wrap in |
I am not sure what exactly this involves -- extend So far, I haven't even used the CMake-based build system of Vigra (my project has been using the Vigra header files directly). I've just tried to compile the full unit-test suite here on my computer using CMake for the first time. I enabled C++20 by adding |
The question is whether this is necessary: you have #511 on your revival checklist, which (because it uses a lambda) would already make C++11 the minimum required C++ standard for Vigra. (On the other hand, the lambda is only used in a .cxx, not in the header-only core implementation of Vigra...) |
If you make a PR I think it is fine to merge and drop compatibility for before C++11, users can pin to version 1.11.1. Thank you for your patience. |
Vigra currently does not compile with Visual Studio 2019 in C++20 mode because of the use of the deprecated functions mentioned in the issue title (which have been removed in C++20).
I would suggest to replace that with the corresponding functionality from
std::allocator_traits
(as in the attached patch), however that has only been available since C++11, and I don't know whether Vigra is still required to work with pre-C++11 compilers?The text was updated successfully, but these errors were encountered: