Fix CIs #514
Fix CIs #514
Conversation
hmaarrfk
force-pushed
the
fix_ci
branch
3 times, most recently
from
b7c1a1a
to
758371c
Compare
|
hmaarrfk
force-pushed
the
fix_ci
branch
8 times, most recently
from
8e26c78
to
30d078b
Compare
hmaarrfk
force-pushed
the
fix_ci
branch
2 times, most recently
from
29f7ba2
to
4b6a29e
Compare
|
@k-dominik I am trying to keep this to a "CI only change" and I think I'm close. I'm struggling with windows. If you have a machine handy and want to debug that would be greatly appreciated. OSX is close, but for some reason i'm getting a segfault. fun! |
|
Hi @hmaarrfk, awesome effort! I'll look into the windows build tomorrow :) |
azure-pipelines.yml
Outdated
| py38: | ||
| PYTHON_VERSION: 3.8 | ||
| py39: | ||
| PYTHON_VERSION: 3.8 |
There was a problem hiding this comment.
| PYTHON_VERSION: 3.8 | |
| PYTHON_VERSION: 3.9 |
There was a problem hiding this comment.
Thank you. please do not feel offended if i squash this in the end. Part of this exercise is trying to be "careful" in not destroying things.
|
Hi @hmaarrfk, is there a reason for the testing strategy with OSX-> py37, linux-> py38, py39, and windows-> py310? |
Just trying to get a "spread" of python versions without building the full matrix. 3 x 4 -> 12 builds is a little "too much". |
Co-authored-by: Dominik Kutra <k-dominik@users.noreply.github.com>
build will fail otherwise would probably better to fix such that also vigranumpy tests are not build with BUILD_TESTS=OFF
this will indirectly force 14.1 toolset when building, otherwise there is a standing issue with 14.2 (VS2019). xref: ref: ukoethe#525
|
@k-dominik i'm somewhat tempted to skip OSX and merge this as is. what do you think? There seems to be a few more PRs to modernize the code base that would go through more easily once we have linux + windows CIs in place. |
|
Hello @hmaarrfk, yes, let's go ahead and merge this. I am always thinking of getting back to vigra and I promise I will ;). Thank you for persisting here! Cheers |
I spoke with ukoethe by email and he agreed that dropping python 2.7 would be ok.
Closes: #502