Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 support #501

Closed
wants to merge 6 commits into from

Conversation

k-dominik
Copy link
Collaborator

Summary:

  • dealt with deprecated Iterable import from collections

@hmeine
Copy link
Collaborator

hmeine commented Jan 7, 2022

The main change looks good to me. I cannot check the CI setup changes, but to me they also look like updates & cleanups that should be merged.

What about the failed checks? CMake failed with vigranumpy dependencies NOT found while TEST_VIGRANUMPY=1 – can that be related to these changes?

@hmeine
Copy link
Collaborator

hmeine commented Jan 7, 2022

Do the CI pipeline changes supercede #490? Would you suggest merging that as well / before this one?

@k-dominik
Copy link
Collaborator Author

Hey @hmeine,

thanks a lot for looking into this!! I'll poke around CI some more (I have avoided azure pipelines so far, so I still have to catch up there a bit). My current issue would be activating the right toolset for python 3.10 (so finding the right vcvarsall.bat or using the right parameters to get 14.2, and I'm not sure where to find it :D).

I'll try to get this running and will ping you again once this is worth looking at (and I formed an opinion on #490).

Cheers and have a great weekend!

@hmaarrfk
Copy link
Collaborator

I merged in the fixes in the code from this branch (trying to keep attribution).

I'm trying to fix the CIs in #514

@k-dominik
Copy link
Collaborator Author

thank you @hmaarrfk,

I'll close this PR then.

@k-dominik k-dominik closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants