-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material UI #299
Material UI #299
Conversation
This comment has been minimized.
This comment has been minimized.
so excited for this! |
hey, my team is really excited for this feature and i was wondering if you'd like some help finishing it? |
Yeah, go for it ) |
…rial-ui time widget
time - show/hide seconds according to timeFormat boolean - use grid for 2 labels select - use renderValue intead of empty value multiselect - new all - don't show placeholer in r/o mode all - use customProps lint fix
modules/components/widgets/material/core/MaterialFieldSelect.jsx
Outdated
Show resolved
Hide resolved
any thoughts on using https://github.com/jonatanklosko/material-ui-confirm for the Material Confirm widget instead of DIY? |
I think we can use it. If you want to submit PR, welcome :) |
* partial material-ui slider widget * finish working on material-ui slider widget * use Number() instead of parse* * customSliderProps * slider * range * fix uncontrolled Co-authored-by: Denis Oblogin <ukrbublik@gmail.com>
i spent some time trying to get the material ui confirm thing to work, and just couldnt figure out how to make renderConfirm render a component because right now its just a click handler. any thoughts? |
|
can i just flexbox the container? not sure how else to get the vertical alignment to work, unless there's a way to target the widget sep class only for mui? |
If it just works and not breaks other skins (antd), yes. If you need to distinguish skin in CSS, you can render root div wrapper with appropriate class like "mui" here I guess: https://github.com/ukrbublik/react-awesome-query-builder/pull/299/files#diff-35a4e08d4dd32566534b002381a4c2611a87a4a447692fc4b632e0f95093dd18R41 |
* use inline-flex and alignment to fix the vertical alignment of to/from labels * fix css formatting * fix formatting * start on materialValueSources using popover and radio btns * nit * lint Co-authored-by: Denis Oblogin <ukrbublik@gmail.com>
@megantaylor Flex approach breaks styles with |
yup, i can do that today |
pushed css solution for from/to labels and value src button alignment for number/date + slider/range |
* better alignment styling for mui widget sep and widget value src * ... Co-authored-by: Denis Oblogin <ukrbublik@gmail.com>
Changed styles a bit. I think now looks good |
anything else i can help with? |
3 checks left (1st is optional). If you want to finish, I'd appreciate |
those 3 tasks are unclear to me, can you be more specific about what needs to be done? |
As for 1st one, compare value select for field "Color" and field select for new rule. In this commit {!hasValue && <MenuItem disabled value={""}>{placeholder}</MenuItem>} and used const renderValue = (selectedValue) => {
if (!readonly && !selectedValue)
return placeholder;
return mapListValues(listValues, ({title, value}) => (value === selectedValue ? title : null)).filter(v => v !== null).shift();
}; So now placeholder will not be rendered as first disabled item "Select value". I would like to use such approach in MaterialFieldSelect In I'll do rest 2 tasks and going to publish MUI support |
@megantaylor Thanks for the help. |
do iiiiiit!!!!! |
Fantastic guys! We will try that on our UI. I yesterday removed antd because of the huge bundle size. As we anyway use material-ui for the rest of our UI, this is great news! Thank you very much for your efforts! |
MaterialTextWidget
MaterialDateWidget
MaterialDateTimeWidget
MaterialTimeWidget
MaterialSelectWidget
MaterialNumberWidget
MaterialSliderWidget
MaterialRangeWidget
MaterialBooleanWidget
MaterialMultiSelectWidget
MaterialFieldSelect
MaterialButton
MaterialButtonGroup
MaterialConjs
MaterialValueSources
MaterialConfirm
MaterialProvider
value
prop oninput
should not be null. Consider using an empty string to clear the component orundefined
for uncontrolled components."Number Between
Number Between
: "Material-UI: You have provided an out-of-range valuenull
for the select component. The available values arevalue
,field
,func
."showLabels: true