Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JsonLogic import for ternary mode #1062

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Conversation

ukrbublik
Copy link
Owner

@ukrbublik ukrbublik commented Jun 13, 2024

Copy link

codesandbox bot commented Jun 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:04pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:04pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:04pm

Copy link

codesandbox-ci bot commented Jun 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a884aa6:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@ukrbublik ukrbublik linked an issue Jun 13, 2024 that may be closed by this pull request
@ukrbublik ukrbublik modified the milestones: ter, Ternary Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 82.66667% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (2310dd2) to head (a884aa6).
Report is 1 commits behind head on master.

Files Patch % Lines
packages/core/modules/import/jsonLogic.js 84.41% 12 Missing ⚠️
packages/ui/modules/components/item/CaseGroup.jsx 62.06% 3 Missing and 8 partials ⚠️
packages/core/modules/utils/validation.js 88.88% 5 Missing ⚠️
packages/ui/modules/components/item/Rule.jsx 66.66% 2 Missing and 3 partials ⚠️
packages/core/modules/import/spel.js 84.21% 3 Missing ⚠️
...i/modules/components/containers/GroupContainer.jsx 60.00% 1 Missing and 1 partial ⚠️
packages/core/modules/utils/defaultUtils.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
- Coverage   82.07%   82.05%   -0.02%     
==========================================
  Files         211      211              
  Lines       10844    10969     +125     
  Branches     1316     1328      +12     
==========================================
+ Hits         8900     9001     +101     
- Misses       1341     1355      +14     
- Partials      603      613      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing Expression Result for Rules for JsonLogic
1 participant