Bootstrap widget kickoff #537
Conversation
…d dev dependencies
|
Sorry, haven't free time to review. |
modules/config/bootstrap/index.js
Outdated
| ...BasicConfig.types, | ||
| number: { | ||
| ...BasicConfig.types.number, | ||
| widgets: { |
There was a problem hiding this comment.
rangeslider (slider with 2 values) will not work for Bootstrap. (Please correct me if I'm wrong)
(You can see how it works for Antd and MUI when you select field=Slider op=Between in demo app)
So please leave
const types = {
...BasicConfig.types,
}
There was a problem hiding this comment.
You were right - fixed this issue.
| let isOnlyIcon = typeToOnlyIcon[type]; | ||
|
|
||
| return ( | ||
| <Button size="small" color={typeToColor[type]} onClick={onClick}> |
There was a problem hiding this comment.
| <Button size="small" color={typeToColor[type]} onClick={onClick}> | |
| <Button size="sm" color={typeToColor[type]} onClick={onClick}> |
There was a problem hiding this comment.
"small" size doesn't even exist in reactstrap docs, I probably mislead myself after copy-pasting the code from vanilla feature. Thanks.
| import React from "react"; | ||
|
|
||
| export default ({children, config}) => { | ||
| return <>{children}</>; |
There was a problem hiding this comment.
| return <>{children}</>; | |
| return <ButtonGroup>{children}</ButtonGroup>; |
import { ButtonGroup } from "reactstrap";There was a problem hiding this comment.
Added. Thanks.
…g rangeslider from bootstrap feature
|
@PedroAMCoelho Thanks for starting work on this! Thanks! |
Hey, @unseen-debatable-net ! There is a pending Pull Request with the rest of the development of this feature (see the Pull Request #585). As I have included at least the basic features in this new bootstrap skin and I'm not going to add anything further for now, a merge with the main branch should be done as soon as this pending Pull Request is reviewed. Thanks! |
* bootstrap widget - initial configs and structure * Implementing button for bootstrap widget * removing unnecessary code * minor fix to bootstrap index.js * removing use confirm from bootstrap widget * removing use confirm from index.js * moving bootstrap and fontawesome dependencies to peer dependencies and dev dependencies * adding reactstrap button group, correcting size of button and removing rangeslider from bootstrap feature
* bootstrap widget - initial configs and structure * Implementing button for bootstrap widget * removing unnecessary code * minor fix to bootstrap index.js * removing use confirm from bootstrap widget * removing use confirm from index.js * moving bootstrap and fontawesome dependencies to peer dependencies and dev dependencies * adding reactstrap button group, correcting size of button and removing rangeslider from bootstrap feature
* bootstrap widget - initial configs and structure * Implementing button for bootstrap widget * removing unnecessary code * minor fix to bootstrap index.js * removing use confirm from bootstrap widget * removing use confirm from index.js * moving bootstrap and fontawesome dependencies to peer dependencies and dev dependencies * adding reactstrap button group, correcting size of button and removing rangeslider from bootstrap feature
* Bootstrap widget kickoff (#537) * bootstrap widget - initial configs and structure * Implementing button for bootstrap widget * removing unnecessary code * minor fix to bootstrap index.js * removing use confirm from bootstrap widget * removing use confirm from index.js * moving bootstrap and fontawesome dependencies to peer dependencies and dev dependencies * adding reactstrap button group, correcting size of button and removing rangeslider from bootstrap feature * Applying Reactstrap input select (#570) * applying reactstrap input select * minor adjustment to multiselect * Bootstrap - Implementing conjs and boolean (#585) * implementing conjs and boolean * adapting the other components with reactstrap Input * implementing dropdown to obtain options with bootstrap styles * stretching dropdown options - bootstrap * adding bootstrap style to multiselect and its options * implementing bootstrap field select * adding margin to group items * minor adjustment to item group spacing and adding key to fix warning * fixing indentation and warning (#606) * improve * cool vs * readme * lint fix * 4.10.0 Co-authored-by: Pedro Coelho <pedrocoelhoprojetos@gmail.com>
Associated issue: #167
IssueHunt Summary
Referenced issues
This pull request has been submitted to: