Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap - Implementing conjs and boolean #585

Merged

Conversation

PedroAMCoelho
Copy link
Contributor

No description provided.

Copy link
Owner

@ukrbublik ukrbublik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ukrbublik ukrbublik merged commit b180514 into ukrbublik:bootstrap Jan 7, 2022
@PedroAMCoelho
Copy link
Contributor Author

Looks good!

Thanks, @ukrbublik ! Denis, perfect timing, a user asked me sooner today in PR #537 about when we will have the bootstrap version in the main branch.

@ukrbublik
Copy link
Owner

@PedroAMCoelho Nice work!
I've created PR to merge it in master, will do it in next 2 days: #604
I found some small issues, will post them in #604, maybe you can help me

@PedroAMCoelho
Copy link
Contributor Author

@PedroAMCoelho Nice work! I've created PR to merge it in master, will do it in next 2 days: #604 I found some small issues, will post them in #604, maybe you can help me

Thanks, Denis. Yes, I can help, but next week my time is more limited. Did you see that the smoke tests complained about indentation this time (in the merge #604 )? Odd, it did not complain before

@ukrbublik
Copy link
Owner

Smoke test is enabled for PRs to master only. So in this PR to bootstrap branch it was disabled.

I've added comment with found issues. It's not blocker, I'll merge #604 soon anyway, issues can be fixed later

ukrbublik pushed a commit that referenced this pull request Jan 18, 2022
* implementing conjs and boolean

* adapting the other components with reactstrap Input

* implementing dropdown to obtain options with bootstrap styles

* stretching dropdown options - bootstrap

* adding bootstrap style to multiselect and its options

* implementing bootstrap field select

* adding margin to group items

* minor adjustment to item group spacing and adding key to fix warning
ukrbublik pushed a commit that referenced this pull request Jan 18, 2022
* implementing conjs and boolean

* adapting the other components with reactstrap Input

* implementing dropdown to obtain options with bootstrap styles

* stretching dropdown options - bootstrap

* adding bootstrap style to multiselect and its options

* implementing bootstrap field select

* adding margin to group items

* minor adjustment to item group spacing and adding key to fix warning
ukrbublik pushed a commit that referenced this pull request Jan 18, 2022
* implementing conjs and boolean

* adapting the other components with reactstrap Input

* implementing dropdown to obtain options with bootstrap styles

* stretching dropdown options - bootstrap

* adding bootstrap style to multiselect and its options

* implementing bootstrap field select

* adding margin to group items

* minor adjustment to item group spacing and adding key to fix warning
ukrbublik added a commit that referenced this pull request Jan 18, 2022
* Bootstrap widget kickoff (#537)

* bootstrap widget - initial configs and structure

* Implementing button for bootstrap widget

* removing unnecessary code

* minor fix to bootstrap index.js

* removing use confirm from bootstrap widget

* removing use confirm from index.js

* moving bootstrap and fontawesome dependencies to peer dependencies and dev dependencies

* adding reactstrap button group, correcting size of button and removing rangeslider from bootstrap feature

* Applying Reactstrap input select (#570)

* applying reactstrap input select

* minor adjustment to multiselect

* Bootstrap - Implementing conjs and boolean (#585)

* implementing conjs and boolean

* adapting the other components with reactstrap Input

* implementing dropdown to obtain options with bootstrap styles

* stretching dropdown options - bootstrap

* adding bootstrap style to multiselect and its options

* implementing bootstrap field select

* adding margin to group items

* minor adjustment to item group spacing and adding key to fix warning

* fixing indentation and warning (#606)

* improve

* cool vs

* readme

* lint fix

* 4.10.0

Co-authored-by: Pedro Coelho <pedrocoelhoprojetos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants