Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: re-add Aventri event feed, now with attendee information #207

Closed
wants to merge 11 commits into from

Conversation

abbas123456
Copy link
Contributor

@abbas123456 abbas123456 commented Feb 2, 2021

NOTE TO SELF: DO NOT MERGE THIS UNTIL uktrade/great-domestic-ui#598 IS MERGED AND DEPLOYED

This PR adds the Aventri feed back into the activity stream, the following API endpoints were used:

https://developer.aventri.com/#list-events
https://developer.aventri.com/#list-attendees
https://developer.aventri.com/#get-event
https://developer.aventri.com/#get-attendee

This feed will be used by great.gov.uk search and Data Flow.

Compared to the previous Aventri feed that was removed in #201 , the event object no longer contains geolocation data and it now contains a list of attendees. There is no longer any filtering done on the events pulled in, this will now be implemented in the great.gov.uk search itself.

See https://trello.com/c/pm9pX3cY/135-aventri-new-pipeline-for-events-data

@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 3 times, most recently from 84fbf1d to d139255 Compare February 2, 2021 18:28
@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 8 times, most recently from 89f5cf9 to 6687414 Compare February 3, 2021 21:36
@abbas123456 abbas123456 requested a review from a team February 3, 2021 21:36
@abbas123456 abbas123456 marked this pull request as ready for review February 3, 2021 21:37
@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 3 times, most recently from d7baa20 to 2da42fe Compare February 4, 2021 10:12
@abbas123456 abbas123456 marked this pull request as draft February 4, 2021 12:14
@abbas123456 abbas123456 marked this pull request as ready for review February 4, 2021 12:53
core/app/feeds.py Outdated Show resolved Hide resolved
@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 3 times, most recently from a72296a to 8ec7427 Compare February 4, 2021 17:14
@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 3 times, most recently from c5e4184 to 7dd98a3 Compare February 8, 2021 16:01
@abbas123456 abbas123456 force-pushed the feature/add_aventri_feed branch 2 times, most recently from 7dfc148 to 85caabe Compare February 9, 2021 18:07
@sekharpanja sekharpanja force-pushed the feature/add_aventri_feed branch 14 times, most recently from d15c196 to 91fcaea Compare February 17, 2021 10:35
@abbas123456
Copy link
Contributor Author

Closing as this is now being superseded by https://github.com/uktrade/activity-stream/tree/feature/add_aventri_feed_michal

@sekharpanja sekharpanja deleted the feature/add_aventri_feed branch January 12, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants