New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: re-add Aventri event feed, now with attendee information #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
3 times, most recently
from
February 2, 2021 18:28
84fbf1d
to
d139255
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
8 times, most recently
from
February 3, 2021 21:36
89f5cf9
to
6687414
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
3 times, most recently
from
February 4, 2021 10:12
d7baa20
to
2da42fe
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
from
February 4, 2021 12:52
2da42fe
to
c7640a6
Compare
abbas123456
commented
Feb 4, 2021
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
3 times, most recently
from
February 4, 2021 17:14
a72296a
to
8ec7427
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
3 times, most recently
from
February 8, 2021 16:01
c5e4184
to
7dd98a3
Compare
samuelhwilliams
approved these changes
Feb 8, 2021
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
from
February 8, 2021 16:14
7dd98a3
to
6948249
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
2 times, most recently
from
February 9, 2021 18:07
7dfc148
to
85caabe
Compare
abbas123456
force-pushed
the
feature/add_aventri_feed
branch
from
February 10, 2021 11:48
85caabe
to
2016696
Compare
sekharpanja
force-pushed
the
feature/add_aventri_feed
branch
14 times, most recently
from
February 17, 2021 10:35
d15c196
to
91fcaea
Compare
sekharpanja
force-pushed
the
feature/add_aventri_feed
branch
from
February 17, 2021 17:11
3bd44a9
to
fa50033
Compare
Closing as this is now being superseded by https://github.com/uktrade/activity-stream/tree/feature/add_aventri_feed_michal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO SELF: DO NOT MERGE THIS UNTIL uktrade/great-domestic-ui#598 IS MERGED AND DEPLOYED
This PR adds the Aventri feed back into the activity stream, the following API endpoints were used:
https://developer.aventri.com/#list-events
https://developer.aventri.com/#list-attendees
https://developer.aventri.com/#get-event
https://developer.aventri.com/#get-attendee
This feed will be used by great.gov.uk search and Data Flow.
Compared to the previous Aventri feed that was removed in #201 , the event object no longer contains geolocation data and it now contains a list of attendees. There is no longer any filtering done on the events pulled in, this will now be implemented in the great.gov.uk search itself.
See https://trello.com/c/pm9pX3cY/135-aventri-new-pipeline-for-events-data