This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
feature: remove Aventri events from the search ElasticSearch query #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ElasticSearch/Activity Stream feed for Aventri is currently disabled but will be re-enabled soon. However once it is re-enabled it will return all events from the Aventri API, in contrast to the original feed which did some filtering. This will cause undesired search results to appear on great.gov.uk if the ElasticSearch query remains as it is. Therefore this commit removes Aventri events from the ElasticSearch query and a separate commit will be pushed at a later stage to update the query with the relevant filters.
abbas123456
force-pushed
the
feature/remove_aventri_events_from_search
branch
from
4c1b163
to
80045ea
Compare
|
Hi @abbas123456 can you please point me out the ticket for this PR? |
|
webbyfox
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Hi @abbas123456 Thanks for it. Can you please add ChangeLog entry as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ElasticSearch/Activity Stream feed for Aventri is currently disabled but will be re-enabled soon. However once it is re-enabled it will return all events from the Aventri API, in contrast to the original feed which did some filtering. This will cause undesired search results to appear on great.gov.uk if the ElasticSearch query remains as it is.
Therefore this PR removes Aventri events from the ElasticSearch query and a separate PR will be raised at a later stage to update the query with the relevant filters.