Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMS-1254] Change blank country choice to "Choose a country" #185

Closed
wants to merge 1 commit into from
Closed

[CMS-1254] Change blank country choice to "Choose a country" #185

wants to merge 1 commit into from

Conversation

kaedroho
Copy link
Contributor

@kaedroho kaedroho commented May 2, 2019

No description provided.

@sdonk
Copy link
Contributor

sdonk commented May 3, 2019

Can you please use the ticket number in the branch name?

eadpearce
eadpearce suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@eadpearce eadpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs update to changelog and setup.py to increment the version

@kaedroho
Copy link
Contributor Author

kaedroho commented May 7, 2019

Will reopen on a non-fork as I now have access

@kaedroho kaedroho closed this May 7, 2019
@kaedroho kaedroho deleted the patch-1 branch May 7, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadpearce eadpearce eadpearce requested changes

@sdonk sdonk sdonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaedroho @sdonk @eadpearce