Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various malformed links arising from " being using in the messages files. #39

Closed
anjackson opened this issue Dec 1, 2017 · 2 comments

Comments

@anjackson
Copy link
Contributor

As raised by Somaya, some links are coming out double-quoted. e.g. https://beta.webarchive.org.uk/en/ukwa/noresults

Looking at the source, it seems the messages files that contain 'over escaped' HTML fragments. e.g.

https://github.com/ukwa/ukwa-ui/blob/master/src/main/resources/i18n/messages.properties#L73

Which creates a link to https://beta.webarchive.org.uk/en/ukwa/"cookies" when the browser tries to make sense of the HTML.

@anjackson
Copy link
Contributor Author

I think I've fixed it, replacing all the " in the messages files with literal " characters.

@ldbiz
Copy link
Collaborator

ldbiz commented Dec 1, 2017

I'd like to say good spot, but that's a major issue; looks like it may have been introduced by the recentish FAQ page changes. Looks ok now.

@ldbiz ldbiz closed this as completed Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants