Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling, cleanup #2

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Conversation

ksiazkowicz
Copy link
Contributor

No description provided.

@ksiazkowicz ksiazkowicz changed the title Improved exception handling Improved exception handling, cleanup Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2 into master will increase coverage by 2.09%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   94.82%   96.91%   +2.09%     
==========================================
  Files           6        7       +1     
  Lines         464      487      +23     
==========================================
+ Hits          440      472      +32     
+ Misses         24       15       -9     
Flag Coverage Δ
#unittests 96.91% <91.17%> (+2.09%) ⬆️
Impacted Files Coverage Δ
aioxrpy/exceptions.py 83.33% <83.33%> (-13.73%) ⬇️
aioxrpy/decimals.py 100.00% <100.00%> (ø)
aioxrpy/definitions.py 100.00% <100.00%> (ø)
aioxrpy/rpc.py 97.05% <100.00%> (+6.14%) ⬆️
aioxrpy/sign.py 98.94% <100.00%> (+12.43%) ⬆️
aioxrpy/serializer.py 96.95% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e452e51...ab6a30e. Read the comment docs.

- Moved drops conversion from RPC to Decimals,
- Reworked aioxrpy.exceptions,
- Added tx signing flow unittest
@ksiazkowicz ksiazkowicz marked this pull request as ready for review April 7, 2020 06:13
@ksiazkowicz ksiazkowicz merged commit cabfb35 into master Apr 7, 2020
@ksiazkowicz ksiazkowicz deleted the exception-handling branch April 7, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant