-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation in the tests to avoid modifying test cases #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to reduce the differences from main in the following parts?
members: []foundation.Member{{ | ||
Address: addrs[1].String(), | ||
Participating: true, | ||
}}, | ||
}, | ||
"empty members": { | ||
operator: addrs[0], | ||
members: []foundation.Member{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were added by accident. As you stated, the purpose of this PR is minimizing the differences. So I should apply these changes in another PR.
@@ -286,15 +280,14 @@ func TestMsgSubmitProposal(t *testing.T) { | |||
valid: true, | |||
}, | |||
"empty proposers": { | |||
proposers: []sdk.AccAddress{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -32,7 +32,6 @@ func TestMsgSend(t *testing.T) { | |||
}, | |||
"empty from": { | |||
contractID: "deadbeef", | |||
from: sdk.AccAddress{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- from: sdk.AccAddress{},
+ from: nil,
@@ -254,12 +246,10 @@ func TestMsgAuthorizeOperator(t *testing.T) { | |||
}, | |||
"invalid holder": { | |||
contractID: "deadbeef", | |||
holder: sdk.AccAddress{}, | |||
operator: addrs[1], | |||
}, | |||
"empty operator": { | |||
holder: addrs[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.