module: add more module/global options #1481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasers
changed the title
lasers
changed the title
lasers
force-pushed
the
module-new-options
branch
3 times, most recently
from
98e83f9
to
5e176d0
Compare
lasers
force-pushed
the
module-new-options
branch
from
5e176d0
to
42fb6be
Compare
|
hey @laser can you split this you have
These all need to be done separately |
lasers
changed the title
|
@tobes You got it, pal. 👍 I wait for other PRs to be merged first before I rebase this. |
tobes
reviewed
Sep 2, 2018
| @@ -71,8 +71,7 @@ overridden by also defining in the individual module. | |||
|
|
|||
| Global options: | |||
|
|
|||
| - ``nagbar_font``. It will be used as an argument to | |||
| ``i3-nagbar -f``, thus setting its font. | |||
| ``nagbar_font``. Specify a font for ``i3-nagbar -f <font>``. | |||
| @@ -93,7 +92,7 @@ Store cache in $XDG_CACHE_HOME or ~/.cache | |||
|
|
|||
| # default behavior | |||
| py3status { | |||
| storage = 'py3status_cache.data' | |||
| storage = 'py3status_cache.data' | |||
| @@ -294,7 +330,7 @@ You can: | |||
| format = "MPD: {state} {artist} {title}" | |||
| } | |||
|
|
|||
| - Unknown placeholders act as if they were static text and placeholders that are empty or None will be removed. | |||
| - Unknown placeholders act as if they were static text and placeholders that are empty or None will be removed. | |||
Closed
|
ping @lasers closing this one since there's too much in it, would be cool to propose only the alpha thing on a simple PR! cheers |
this PR is not that, closing, open a new one if you wish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1078.