Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel building updates #473

Merged
merged 5 commits into from Sep 10, 2021
Merged

Wheel building updates #473

merged 5 commits into from Sep 10, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 10, 2021

Follow on from #472.

Changes proposed in this pull request:

  • Now we're using manylinux2014, we can use the prebuilt manylinux2014_aarch64 image instead of building our own

  • Replace archived crazy-max/ghaction-docker-buildx action with the official Docker ones

  • Build each manylinux/Python combination in its own job

    • Main reason is aarch64 is slow, takes about 21 minutes in serial
    • Can still run scripts/build-manylinux-wheels.sh (locally) without specifying the Python version to build all if wanted
  • Split the Windows/macOS and Linux workflows into their own files, makes the file shorter and the logic simpler, can easily diff them to see common parts, and makes it easier to build the Linux matrix

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Sep 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #473 (c7125ad) into main (2b13dc4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files           6        6           
  Lines        1685     1685           
=======================================
  Hits         1499     1499           
  Misses        186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b13dc4...c7125ad. Read the comment docs.

@hugovk hugovk merged commit f23afd0 into ultrajson:main Sep 10, 2021
27 checks passed
@hugovk hugovk deleted the manylinux2014_aarch64 branch September 10, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants