Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional toggle for adding of TrackedPoseDriver #1409

Merged

Conversation

MattGrayUL
Copy link
Contributor

@MattGrayUL MattGrayUL commented Mar 2, 2023

Summary

Allow users that do not require a TrackedPoseDriver to optionally turn off the automatic creation of TrackedPoseDrivers from the LeapXRServiceProvider

Contributor Tasks

These tasks are for the merge request creator to tick off when creating a merge request.

  • Pair review with a member of the QA team.
  • Add any release testing considerations to the MR for the next release.
  • Check any relevant CHANGELOG files have been updated.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
  • Add any relevant labels such as breaking to this MR.
  • If this MR closes a Jira issue, make sure the fix version on the JIRA issue is set to the correct one.

Reviewer Tasks

Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

Use emojis in review threads to communicate intent and help contributors.

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • Documentation has been reviewed. Includes checking documentation requirements are met and not missing e.g., public API is commented.
  • Checked and agree with release testing considerations added to MR for the next release.

Closes JIRA Issue

Closes UNITY-984

@MaxPalmer-UH MaxPalmer-UH merged commit 8ae52f5 into develop Mar 7, 2023
@MaxPalmer-UH MaxPalmer-UH deleted the feature/UNITY-984-Make_TrackedPoseDriver_Optional branch March 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants