Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Retrieve Direct Download URL of Dataset Using HUB SDK #109

Conversation

hassaanfarooq01
Copy link
Contributor

@hassaanfarooq01 hassaanfarooq01 commented Mar 11, 2024

Fetching the download URL directly from the Firebase Datasets get API instead of making a call to the storage API endpoint.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Simplified dataset download link generation in hub-sdk.

📊 Key Changes

  • Removed the requirement to specify a file type when getting a dataset download link.
  • Streamlined the process to get the dataset download link directly from stored data, removing external requests and error handling related to this process.

🎯 Purpose & Impact

  • Simplification: This change simplifies the process for developers and users to get a download link for datasets, making the SDK more user-friendly.
  • Efficiency: Reduces the complexity and potential for errors by eliminating unnecessary parameters and steps, leading to faster and more reliable operations.
  • User Experience Improvement: Eases the integration process for users needing to access their datasets, potentially enhancing the overall satisfaction with the Ultralytics platform.

🚀 These adjustments make the SDK more straightforward and efficient, positively impacting developers and users by improving accessibility and ease of use.

Copy link

@priytosh-tripathi priytosh-tripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiuwaxmann sergiuwaxmann merged commit 60d9802 into feat/enabled-all-features Mar 22, 2024
3 checks passed
@sergiuwaxmann sergiuwaxmann deleted the fix/HUB-696/unable_to_retrieve_direct_download_URL_dataset branch March 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants