Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to CI #94

Closed
wants to merge 5 commits into from
Closed

Add tests to CI #94

wants to merge 5 commits into from

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 27, 2024

@kalenmike @hassaanfarooq01 adds tests to CI. All failing currently, same as when I run them locally with pytest tests

@hassaanfarooq01 we need to get to the point where this command passes in the CI (just like I have in ultralytics with pytest tests). You're free to add and call any secrets you need to for this to work correctly.

Screenshot 2024-01-27 at 23 25 41

๐Ÿ› ๏ธ PR Summary

Made with โค๏ธ by Ultralytics Actions

๐ŸŒŸ Summary

New automated testing across different operating systems and Python versions, updated documentation plugin, and test file reorganization.

๐Ÿ“Š Key Changes

  • ๐Ÿงช Expanded Testing Strategy:
    • Added cross-platform testing on ubuntu-latest, macos-latest, and windows-latest.
    • Included multiple Python versions 3.8 and 3.11 in the test matrix.
    • Implemented Pytest for running tests and Codecov for coverage reporting.
  • ๐Ÿ“ Documentation Plugin Update:
    • Updated mkdocs-ultralytics-plugin from version 0.0.40 to 0.0.42.
  • ๐Ÿ“ Test File Renaming:
    • Renamed test files for consistency and clarity (e.g., from testCase_dataset.py to test_dataset.py).
  • ๐Ÿšฎ Test File Deletion:
    • Removed an unused test file test.py.

๐ŸŽฏ Purpose & Impact

  • ๐ŸŒ Broader Compatibility Assurance:
    • The inclusion of different operating systems and Python versions ensures compatibility and reliability for a wider range of users.
  • ๐Ÿ” Improved Test Coverage and Insights:
    • Enhanced testing coverage and integration with Codecov help maintain high code quality and identify potential issues early.
  • ๐Ÿ“š Enhanced Documentation:
    • The upgraded plugin provides better support for documentation features like meta descriptions, images, authors, and dates.
  • ๐Ÿงน Codebase Cleanliness:
    • Renaming and removal of test files increase the readability and maintainability of the test suite, making it easier for developers to navigate and understand.

The changes enhance the developer experience and contribute to the robustness of Ultralytics' software, while end-users can expect more reliable updates and consistent performance across different platforms and Python editions.

@glenn-jocher
Copy link
Member Author

@hassaanfarooq01 I've opened this nearly two months ago and I see no progress here. Why not?

We need tests for this product, it's not acceptable that months after release there is no GitHub CI in place here.

@sergiuwaxmann

@hassaanfarooq01
Copy link
Member

hassaanfarooq01 commented Mar 27, 2024

@hassaanfarooq01 I've opened this nearly two months ago and I see no progress here. Why not?

We need tests for this product, it's not acceptable that months after release there is no GitHub CI in place here.

@sergiuwaxmann

@glenn-jocher After, we've moved to cloud-based training work and have begun work for cloud training

Base automatically changed from todo-delete-this-branch to main March 31, 2024 22:48
@glenn-jocher
Copy link
Member Author

@sergiuwaxmann @yogendrasinghx closing this PR in favor of #116

@glenn-jocher glenn-jocher deleted the tests branch April 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants