Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/enabled all features #91

Merged
merged 13 commits into from Mar 23, 2024
Merged

Feat/enabled all features #91

merged 13 commits into from Mar 23, 2024

Conversation

hassaanfarooq01
Copy link
Member

@hassaanfarooq01 hassaanfarooq01 commented Jan 24, 2024

Enabled all features of SDK in branch.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements and simplifications to Ultralytics Hub SDK for better usability and functionality. πŸš€

πŸ“Š Key Changes

  • Added .idea to .gitignore for better developer experience. πŸ› οΈ
  • Simplified the process to get dataset and model download URLs in documentation. πŸ“š
  • Enhanced flexibility in listing datasets, models, and projects with optional public parameters. πŸ‘₯
  • Streamlined methods for retrieving dataset and model resources, focusing on clarity and direct access. πŸ’Ό
  • Introduced and adjusted various SDK functionalities to improve user interaction with datasets, models, and projects. 🧰

🎯 Purpose & Impact

  • Enhanced Developer Experience: Ignoring .idea prevents unnecessary files from cluttering the repository. 🧹
  • Simplified Access: Changes in getting download links make it easier for users to access their data and model weights, improving workflow efficiency. πŸ–‡οΈ
  • Increased Flexibility: The optional public parameters allow for more tailored queries when listing resources, benefiting users who need to differentiate between public and private items. πŸ”
  • Direct Resource Access: By directly retrieving URLs for datasets and model weights, users can streamline their workflows, leading to a more efficient project management process. ⏩
  • Overall Benefit: These updates aim to improve the usability of the Hub SDK, making it more intuitive and flexible for developers and AI researchers. 🌈

@glenn-jocher
Copy link
Member

@hassaanfarooq01 @sergiuwaxmann is this ready to merge? What's the status here?

I'm extremely uncomfortable merging any changes here as we completely lack GitHub CI, so there's no way for me to know that what you've changed here @hassaanfarooq01 will not break main/develop branches.

@glenn-jocher
Copy link
Member

@hassaanfarooq01 see #94

@sergiuwaxmann
Copy link
Member

@glenn-jocher These are changes that @hassaanfarooq01 said we need to merge to fix existing issue raised by @yogendrasinghx. If I am not mistaking, @yogendrasinghx is currently testing these changes.

I agree, we should prioritize adding tests so we can safely merge changes.
@hassaanfarooq01 Please focus on adding tests to HUB SDK and if possible, explain the changes on this branch to @glenn-jocher.

@glenn-jocher
Copy link
Member

@sergiuwaxmann @hassaanfarooq01 @yogendrasinghx I'm merging this PR solely based on your opinions here that it needs to be merged, I'm blind to see if this will cause any downstream issues but don't want to stand in the way of further development.

If we are to keep this repo and not delete it then it absolutely requires tests and CI, the current status is completely unnacceptable.

@glenn-jocher glenn-jocher merged commit 6189733 into develop Mar 23, 2024
3 checks passed
@glenn-jocher glenn-jocher deleted the feat/enabled-all-features branch March 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants