-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ultralytics 8.2.14
add task
+ OBB to hub.check_dataset()
#12573
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12573 +/- ##
==========================================
+ Coverage 70.51% 70.65% +0.13%
==========================================
Files 122 122
Lines 15621 15622 +1
==========================================
+ Hits 11015 11037 +22
+ Misses 4606 4585 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
check_dataset
to use required arguments
@Burhan-Q this looks good! Can you add examples for checking OBB and Classify datasets too to the docstring? |
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
I think we should be testing these in the tests, let me see. Ok OBB was missing so I've added it in 869606c @sergiuwaxmann @Burhan-Q guys BTW it seems logical to add an |
Looks like the CI test fails on OBB since the task is not included in the Adding an |
@Burhan-Q @sergiuwaxmann oh perfect, then we've caught a bug in OBB checks here. We should fix this in this PR. |
@Burhan-Q @sergiuwaxmann wait now I'm really confused, because if check_dataset doesn't work at all for OBB, then how do we have OBB datasets in HUB? Where did the JSON files with the labels come from if this step is failing?? |
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
check_dataset
to use required argumentsultralytics 8.2.13
add task
and OBB to hub.check_dataset()
ultralytics 8.2.13
add task
and OBB to hub.check_dataset()
ultralytics 8.2.14
add task
and OBB to hub.check_dataset()
ultralytics 8.2.14
add task
and OBB to hub.check_dataset()
ultralytics 8.2.14
add task
+ OBB to hub.check_dataset()
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
…lytics#12573) Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com> Co-authored-by: UltralyticsAssistant <web@ultralytics.com> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Summary
Proposed change is to make both arguments mandatory when using
check_dataset
since currently there are default values for bothpath
andtask
. This makes it possible to run function without providing values for either argument, which throws an error that is likely to be difficult to interpret.Additionally, given the default value for the
task
argument, thecheck_dataset
function will pass a dataset even if it's the incorrect task, and is likely to cause problems when user attempts to upload the dataset to HUB; see ultralytics/hub#681. This change also adds type hinting for the function arguments, return value, and updates the function docstring per the changes proposed plus includes missingobb
task from the supported tasks.Current behavior without specifying task, check passes as "detect" task on pose dataset
Current behavior with no arguments provided, ambiguous error shown
Proposed changes behavior
Additional work needed
Fundamentally, the underlying process might need to address what
task
the dataset actually is versus what is passed to thetask
argument. However, since that would require much more time, this seemed to be a simpler solution to avoid the issue, since users are less likely to provide the incorrect argument, which would end up costing them more time.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved type enforcement and task range in
check_dataset
function.📊 Key Changes
path
andtask
parameters in thecheck_dataset
function are no longer optional. Users must specify these when calling the function.🎯 Purpose & Impact
check_dataset
function, allowing for more diversified dataset uploads to the Ultralytics HUB. This update potentially benefits researchers and developers in fields requiring oriented bounding box data, such as satellite imagery analysis and certain types of object detection.👩💻 For developers, these changes mean more robust and versatile tools at their disposal.
🌍 For users, expect smoother experiences and support for more dataset types in applications powered by Ultralytics technology.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancements in model visualization, dataset tasks extension, and minor version bump.
📊 Key Changes
TASKS
list and expanded the use ofTASKS
for better clarity and modularity.visualize=True
.🎯 Purpose & Impact