-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checks #36
Update checks #36
Conversation
for more information, see https://pre-commit.ci
@AyushExel I'm getting stuck on circular imports all over the place now. This is what I was warning about if we broke general.py up into many smaller files. |
@glenn-jocher where exactly? I didn't encounter any in the classification training or validation. |
@AyushExel maybe we should re-merge some of these smaller files back together. Right now in this PR checks requires loggers, and loggers requires checks. The way you had it before checks like is_colab() are embedded into loggers to avoid an import, duplicating code and increasing maintenance, and complicating the usage of checks in other places we might want them. |
My main idea with general.py is that is requires almost no imports, so it's a place for low level functions that don't have any external import requirements. This simplifies development since functions from general.py can be imported almost anywhere without any circular import concerns. But here with general.py broken into many small files we increase circular import occurrences. |
@glenn-jocher right okay. Then merge this one but hold on a bit after that because the segmentation PR is already very large and rebasing it against master will cause many conflicts after these changes. |
@AyushExel ok got it. What's the timeline on the segmentation PR merge looking like? |
@glenn-jocher I'm hoping to make the pr by late night/early morning today or by latest tomorrow |
@AyushExel ok no worries I'll just wait for that first and then get back to this one. |
Closing to focus on #40 |
Brought in some additional checks from YOLOv5 and restored is_colab() and is_kaggle() functions.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancements to environment checks and system setup in the Ultralytics YOLOv5 software.
📊 Key Changes
check_system
function reports CPU count, RAM, and disk space, providing a clear overview of the system's resources.is_ascii
function, consolidated checks for Colab and Kaggle environments into their respective utility functions.set_logging
to use new utility functions to determine the Colab or Kaggle environment, streamlining the logging initialization process.🎯 Purpose & Impact
check_system
function offers immediate and user-friendly feedback on the current operating environment, helping users diagnose and resolve potential issues swiftly.