Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation support & other enchancements #40

Merged
merged 32 commits into from
Nov 8, 2022
Merged

Segmentation support & other enchancements #40

merged 32 commits into from
Nov 8, 2022

Conversation

AyushExel
Copy link
Contributor

@AyushExel AyushExel commented Nov 7, 2022

  • Segmentation support
  • More robust validator

This PR has not been cleaned up.. Dataset path is hardcoded.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improvements to model CI, dataset handling, and segmentation training.

📊 Key Changes

  • CI configuration updated to include latest PyTorch version and removed specified torch versions.
  • Dataset processing in train.py now handles COCO and ImageNet more intelligently.
  • Added new segmentation training algorithms with smooth loss calculations.
  • NotImplementedErrors replaced with concrete implementations in some classes.
  • YAML files for YOLOv5 models added, defining network architectures.
  • Default training configurations now reflect changes made to dataset handling and model configuration locations.

🎯 Purpose & Impact

  • CI changes ensure tests run with the most up-to-date PyTorch framework, improving compatibility.
  • Enhanced dataset handling provides a scaffold for more robust training on standard datasets like COCO and ImageNet.
  • Segmentation-focused code introduces an expanded usage scope of the Ultralytics framework, catering to more tasks than object detection.
  • YAML-based model definitions modularize architecture configurations, facilitating easier experimentation and adjustments.
  • Changes impact users by broadening the ease of training custom models and utilzing the framework for tasks beyond traditional object detection.

@glenn-jocher
Copy link
Member

@AyushExel resolved conflicts and merged master. You should git pull and make sure the updates didn't break your seg training.

@glenn-jocher
Copy link
Member

@AyushExel pre-commit's got a bunch of valid errors here we need to work through following the main merge.
https://results.pre-commit.ci/run/github/535360445/1667852320.wmgI6kxoRCuwwgNUUlI0dg
Screenshot 2022-11-07 at 21 20 15

@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2022
@AyushExel
Copy link
Contributor Author

@glenn-jocher now segmentation auto downloads coco128-seg so it can be tested like:

 python yolo/v8/segment/train.py img_size=64

@glenn-jocher
Copy link
Member

@AyushExel awesome! I'll test locally and then update CI with a seg training

@glenn-jocher
Copy link
Member

glenn-jocher commented Nov 8, 2022

@AyushExel I'm getting FileNotFoundError: [Errno 2] No such file or directory: 'yolov5n-seg.yaml', so I added it to the repo under a new v8/models directory.

After this it still doesn't find it, so it looks like check_yaml() and check_file() have not been ported over from v5. The purpose of these functions is to search ROOT for instances of the filename if it is not found in the CWD, which allows simplifying CLI commands. I think we need to add this in and apply check_yaml() to all --cfg and --data arguments.

@AyushExel
Copy link
Contributor Author

@glenn-jocher should work now. Let's port check functions from v5 in the next step

@glenn-jocher glenn-jocher merged commit f56c9bc into main Nov 8, 2022
@glenn-jocher glenn-jocher deleted the callbacks branch November 8, 2022 15:27
@glenn-jocher
Copy link
Member

@AyushExel PR merged!

AyushExel added a commit that referenced this pull request Nov 15, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
0iui0 pushed a commit to 0iui0/ultralytics that referenced this pull request Jan 3, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants