Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched from Travis to GitHub Actions #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switched from Travis to GitHub Actions #26

wants to merge 1 commit into from

Conversation

HorizonNet
Copy link
Member

Solves #25

@HorizonNet HorizonNet added the enhancement New feature or request label May 10, 2020
@HorizonNet HorizonNet self-assigned this May 10, 2020
@HorizonNet HorizonNet force-pushed the switch-to-actions branch 2 times, most recently from 41d9b28 to 5eeb9ff Compare May 10, 2020 16:44
@HorizonNet HorizonNet requested a review from anis016 May 10, 2020 17:00
nightscape
nightscape reviewed May 5, 2021
View reviewed changes
tests/test.yml
@@ -15,11 +15,22 @@
when: ansible_os_family == 'RedHat'

roles:
- { role: "{{ playbook_dir | dirname }}", kerberos_server_realm_name: "TEST.COM", kerberos_server_users: [{ name: user1, password: password, state: present }, { name: user2, password: password, state: absent }]}
- { role: "{{ playbook_dir | dirname }}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to write this with less curly and square braces/brackets:

    - role: "{{ playbook_dir | dirname }}"
      kerberos_server_realm_name: "TEST.COM"
      kerberos_server_users:
        - name: user1
          password: password
          state: present
        - name: user2
          password: password
          state: absent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightscape nightscape nightscape left review comments

@anis016 anis016 Awaiting requested review from anis016

At least 1 approving review is required to merge this pull request.

Assignees

@HorizonNet HorizonNet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HorizonNet @nightscape