Skip to content

Commit

Permalink
formats: Remove problem causing part of duplicate detection in h26x
Browse files Browse the repository at this point in the history
There are legitimate situations where different NAL units get same
timestamp. This commit removes discarding for Single NAL units because
of this situation.
  • Loading branch information
jrsnen committed Nov 24, 2022
1 parent 5ca3c13 commit c07a8c2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/formats/h26x.cc
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,10 @@ rtp_error_t uvgrtp::formats::h26x::packet_handler(int rce_flags, uvgrtp::frame::
else if (frag_type == uvgrtp::formats::FRAG_TYPE::FT_NOT_FRAG) { // Single NAL unit

// TODO: Check if previous dependencies have been sent forward
completed_ts_[frame->header.timestamp] = std::chrono::high_resolution_clock::now();

// TODO: We should detect duplicate packets, but there are legitimate situations
// where single NAL units have same timestamps
//completed_ts_[frame->header.timestamp] = std::chrono::high_resolution_clock::now();

// nothing special needs to be done, just possibly add start codes back
prepend_start_code(rce_flags, out);
Expand Down

0 comments on commit c07a8c2

Please sign in to comment.