Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion panics for unrecognized commands #81

Closed
aw-bib opened this issue Apr 11, 2023 · 1 comment
Closed

Tab completion panics for unrecognized commands #81

aw-bib opened this issue Apr 11, 2023 · 1 comment
Assignees
Milestone

Comments

@aw-bib
Copy link

aw-bib commented Apr 11, 2023

It seems that if I use :vertical ro and try to expand rooms via the tab-key iamb crashes

thread 'main' panicked at 'unknown command vertical', /home/arwagner/.cargo/registry/src/github.com-1ecc6299db9ec823/iamb-0.0.7/src/base.rs:868:14
stack backtrace:
   0: rust_begin_unwind
             at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/core/src/panicking.rs:64:14
   2: <modalkit::editing::buffer::EditBuffer<I> as modalkit::editing::action::Editable<(modalkit::editing::buffer::CursorGroupId,&modalkit::editing::base::ViewportContext<modalkit::editing::cursor::Cursor>,&C),modalkit::editing::store::Store<I>,I>>::editor_command
   3: <modalkit::widgets::textbox::TextBoxState<I> as modalkit::editing::action::Editable<C,modalkit::editing::store::Store<I>,I>>::editor_command
   4: iamb::run::{{closure}}.16163
   5: tokio::runtime::runtime::Runtime::block_on
   6: iamb::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

(same for :horizontal ro<tab>).

  • iamb 0.0.7
  • Ubuntu 20.04.6 LTS (Focal Fossa)
  • rustc 1.68.0 (2c8cc3432 2023-03-06)

via cargo install --locked iamb

@ulyssa ulyssa self-assigned this Apr 17, 2023
@ulyssa ulyssa changed the title :vertical ro<tab> crashes Tab completion panics for unrecognized commands Apr 17, 2023
@ulyssa
Copy link
Owner

ulyssa commented Apr 17, 2023

Thank you for catching and reporting this! It looks like I made the default case for commands to panic when I added this in #44 , but then forgot to change it.

@ulyssa ulyssa added this to the v0.0.8 milestone Apr 17, 2023
@ulyssa ulyssa closed this as completed May 2, 2023
@ulyssa ulyssa mentioned this issue Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants