Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datalayers format change broke my maps #1714

Closed
baikiet opened this issue Mar 27, 2024 · 2 comments · Fixed by #1717
Closed

datalayers format change broke my maps #1714

baikiet opened this issue Mar 27, 2024 · 2 comments · Fixed by #1717
Labels

Comments

@baikiet
Copy link

baikiet commented Mar 27, 2024

Describe the bug
I built a map with a few layers, some combinations of which I embed on a website. The way layers are named in the URL seems to have changed. That broke the website. For example, I am embedding this URL :

https://umap.openstreetmap.fr/en/map/vol-libre-jura_980516?datalayers=3058582#11/47.2767/7.3087

That was working fine until a few days/weeks ago. Now it doesn't show the layer. The new correct URL seems to be this:

https://umap.openstreetmap.fr/en/map/vol-libre-jura_980516?datalayers=159d6396-daf5-48cf-a523-7b6c5c1be3d3#11/47.2767/7.3087

To Reproduce
See above.

Expected behavior
Valid URL should not change.
https://www.w3.org/Provider/Style/URI

If the change/breakage was inevitable, some sort of notification to users would have been unavoidable.

Additional context
I believe this is related to a change from ID to UUID for layers. I found a related commit in 1b41ff0 but there is no explanation of why or whether there was an intention for this to be backwards compatible.

@baikiet baikiet added the bug label Mar 27, 2024
@baikiet
Copy link
Author

baikiet commented Mar 27, 2024

I fixed the URLs linked from https://vollibrejura.ch/spots-vlj/

The following ones are still broken:
https://vollibrejura.ch/?page_id=19200
https://vollibrejura.ch/?page_id=20321
https://vollibrejura.ch/?page_id=20208
https://vollibrejura.ch/?page_id=20273

Can you please confirm whether that's something you plan to fix on your side or should I fix manually on my side?

@yohanboniface
Copy link
Member

Thanks for the report, and sorry for the inconvenience.
The datalayer id have indeed changed, and this use case seem to be missing from our test cases / radar, and I'm sorry for that.
We'll have a look now. Hopefully we'll have a fix on our side, I'll let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants