You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the caption popup, notice the extra spacing below the popup heading
Expected behavior
More proportional spacing expected as shown in preferred version at bottom
Screenshots
Desktop (please complete the following information):
OS: Win11
Browser Edge
Version 125.0.2535.51
Additional context
The popup underlying template is as such:
# {Type} de {Guichet}
Agence: **{Agence}**
Commune: **{Commune}**
Cercle: **{Cercle}**
Année de Création: **{Annee_Creation}**
Accessibilité: **{Accessibilite}**
It appears the code is using <br> elements to implement line breaks. However the # markup also calls for <h3>, hence the final code has <h3><br> which creates a double line break, hence the extra space. Also line height for <h3> is set to 3.
I have removed the extra <br> below <h3> and set line-height to 1.75 in my preferred version below
The text was updated successfully, but these errors were encountered:
Basically, we do not add `<br>` anymore, but instead let the newline
and use the css `white-space: pre-line;`. Also remove new lines after
title.
While doing that change, I needed to reorder regex so the ones needing
a newline before would still have it (bullets points).
I've added tests and removed some to cover those changes.
fix#1854
Describe the bug
There is too much spacing in the caption popup when using the # markup.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
More proportional spacing expected as shown in preferred version at bottom
Screenshots
![image](https://private-user-images.githubusercontent.com/267163/332984138-ede82575-4617-464c-b756-da2151eb7f5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzMTYxNTYsIm5iZiI6MTcyMDMxNTg1NiwicGF0aCI6Ii8yNjcxNjMvMzMyOTg0MTM4LWVkZTgyNTc1LTQ2MTctNDY0Yy1iNzU2LWRhMjE1MWViN2Y1Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwN1QwMTMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yM2Q0ODFmZjI4YWMzNTUwNWRjN2QxZTU4YmM1OGJkZDFhMjRlNDJmNTE5MTRiYzUwNTA4ZTllNWRjZDNmYmQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._bvKSbn8_pagSlWVUeTpisEEcFNn7icbYy5xJljb520)
Desktop (please complete the following information):
Additional context
The popup underlying template is as such:
It appears the code is using
<br>
elements to implement line breaks. However the # markup also calls for<h3>
, hence the final code has<h3><br>
which creates a double line break, hence the extra space. Also line height for<h3>
is set to 3.I have removed the extra
<br>
below<h3>
and set line-height to 1.75 in my preferred version belowThe text was updated successfully, but these errors were encountered: