fix: refactor new line management in popups #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, we do not add `<br>` anymore, but instead let the newline and use the css `white-space: pre-line;`. Also remove new lines after title. While doing that change, I needed to reorder regex so the ones needing a newline before would still have it (bullets points). I've added tests and removed some to cover those changes. fix #1854
davidbgk
approved these changes
May 29, 2024
|
Moving to markdown is clearly an option at some point, but at this stage our syntax is not compatible with Markdown, it's a Yoyodown thing :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we do not add
<br>anymore, but instead let the newline and use the csswhite-space: pre-line;. Also remove new lines after title.While doing that change, I needed to reorder regex so the ones needing a newline before would still have it (bullets points).
I've added tests and removed some to cover those changes.
fix #1854