Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if unmodified pre 1.3.0 #1216

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix if unmodified pre 1.3.0 #1216

merged 2 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Use ns time for geojson and gzipped geojson mtime

    @yohanboniface
    yohanboniface committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f69c959 View commit details
    Browse the repository at this point in the history

  2. Use gzip mtime for Last-Modified comparison when in gzip mode 

    Prior to 1.3.0, uMap was not setting the gzip mtime, so it was
whatever the time it get requested at first.
Since 1.3.0:
- when creating the geojson.gzip, we also force its mtime to be
  the geojson one
- we replaced If-Match by If-Unmodified, which relies on Last-Modified

When uMap is served by a proxy like Nginx (and X-Accel-Redirect),
and if user accepts gzip, then the Last-Modified would be the gzip
one, not the flat geojson one.

So when comparing that value in a subsequent update, we need to
compare with the correct value.

fix #1212
    @yohanboniface
    yohanboniface committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    13a1c3b View commit details
    Browse the repository at this point in the history