Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vhpidirect: add 'quickstart/package' #7

Merged
merged 8 commits into from
Apr 17, 2020
Merged

vhpidirect: add 'quickstart/package' #7

merged 8 commits into from
Apr 17, 2020

Conversation

radonnachie
Copy link

As per (/pull/4):

Actually, you might want to keep this PR as is, and open another simpler one.

This merely calls a packaged print function from c in 2 entities

@radonnachie radonnachie mentioned this pull request Apr 14, 2020
Closed
9 tasks
@radonnachie radonnachie changed the title C package simple package example (simple) Apr 14, 2020
@radonnachie radonnachie changed the title package example (simple) quickstart/package example (simple) Apr 14, 2020
umarcor
umarcor requested changes Apr 14, 2020
View reviewed changes
Copy link
Owner

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocketRoss, see attached comments. Apart from those mostly style issues, the content is good. I think you can go ahead and add the corresponding reference in the docs (doc/vhpidirect/examples/quickstart.rst) during this iteration!

vhpidirect/quickstart/package/ent1.vhd Outdated Show resolved Hide resolved
vhpidirect/quickstart/package/pkg.vhd Outdated Show resolved Hide resolved
vhpidirect/quickstart/package/run.sh Outdated Show resolved Hide resolved
vhpidirect/quickstart/package/tb.vhd Outdated Show resolved Hide resolved
vhpidirect/quickstart/package/tb.vhd Outdated Show resolved Hide resolved
@umarcor umarcor mentioned this pull request Apr 14, 2020
Closed
umarcor
umarcor reviewed Apr 15, 2020
View reviewed changes
Copy link
Owner

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that only the docs are missing!

@umarcor
Copy link
Owner

umarcor commented Apr 17, 2020 •
edited
Loading

@RocketRoss, I think we should prioritize this. Don't worry about the style/naming. Just add a brief description to the docs and we'll have it merged. When we are done merging this set of examples, I'll do a general check for styles...

EDIT

Touché.

umarcor
umarcor approved these changes Apr 17, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
doc/vhpidirect/examples/quickstart.rst Outdated Show resolved Hide resolved
doc/vhpidirect/examples/quickstart.rst Outdated Show resolved Hide resolved
@radonnachie radonnachie mentioned this pull request Apr 17, 2020
Closed
This was referenced Apr 17, 2020
Open
Closed
@umarcor umarcor changed the title quickstart/package example (simple) vhpidirect: add 'quickstart/package' Apr 17, 2020
@umarcor umarcor merged commit 95a760d into umarcor:master Apr 17, 2020
@umarcor umarcor mentioned this pull request Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umarcor umarcor umarcor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radonnachie @umarcor