Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update deps/open62541 digest to 258d6ad #1080

Merged
merged 7 commits into from
Aug 4, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 1, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
deps/open62541 digest 7d602cb -> 258d6ad

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update deps/open62541 digest to 546e0e2 chore(deps): update deps/open62541 digest to 2d3e1b0 Jun 1, 2023
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch from a89e368 to 09ccca7 Compare June 1, 2023 21:54
@renovate renovate bot changed the title chore(deps): update deps/open62541 digest to 2d3e1b0 chore(deps): update deps/open62541 digest to 9027198 Jun 5, 2023
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch from 09ccca7 to 3a7256d Compare June 5, 2023 12:38
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch 2 times, most recently from c365a06 to 0fc218d Compare June 7, 2023 10:34
@ccvca
Copy link
Member

ccvca commented Jun 7, 2023

Looks like, there is a new method for loading companion specifications:
open62541/open62541@546e0e2#diff-a3722125e443bb2834748881e3847cc8814e8880fe2b20e7b0dd227f0759bb03

I don't known why the original method is broken.

@renovate renovate bot changed the title chore(deps): update deps/open62541 digest to 9027198 chore(deps): update deps/open62541 digest to 9d219c6 Jun 9, 2023
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch 6 times, most recently from 04b3fb8 to 3902c32 Compare June 11, 2023 16:37
@GoetzGoerisch
Copy link
Member

@NoelGraf do you have an idea, why the old nodeset generation is now failing?

@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch 2 times, most recently from 30de62f to 5c481f4 Compare June 12, 2023 05:57
@ccvca
Copy link
Member

ccvca commented Jun 12, 2023

Each CS without types causes this is the error:

#define UA_TYPES_PADIM_COUNT 0
#define UA_TYPES_PADIM NULL
/* Change namespaceIndex from current namespace */
for(int i = 0; i < UA_TYPES_PADIM_COUNT; i++) {
UA_TYPES_PADIM[i].typeId.namespaceIndex = ns[2];
UA_TYPES_PADIM[i].binaryEncodingId.namespaceIndex = ns[2];
}

@renovate renovate bot changed the title chore(deps): update deps/open62541 digest to 9d219c6 chore(deps): update deps/open62541 digest to f481959 Jun 12, 2023
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch from 5c481f4 to da1387e Compare June 12, 2023 07:36
@ccvca
Copy link
Member

ccvca commented Jun 12, 2023

This is a bug in the current open62541 release: open62541/open62541#5814

@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch from da1387e to dcd911b Compare June 13, 2023 06:29
@renovate renovate bot changed the title chore(deps): update deps/open62541 digest to f481959 chore(deps): update deps/open62541 digest to 0b1d72f Jun 13, 2023
@renovate renovate bot force-pushed the renovate/deps-open62541-digest branch 6 times, most recently from 4f90e9b to 6aaebc8 Compare June 16, 2023 07:44
@ccvca
Copy link
Member

ccvca commented Jul 7, 2023

The original Error seems to be gone, but now GMS has a problem:

/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c: In function β€˜function_namespace_gms_generated_106_begin’:
/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c:3535:73: error: β€˜UA_TYPES_MACHINETOOL_WORKSPACETYPE’ undeclared (first use in this function); did you mean β€˜UA_TYPES_MACHINETOOL_PARTQUALITY’?
 3535 | UA_init(variablenode_ns_6_i_6001_WorkspaceType_0, &UA_TYPES_MACHINETOOL[UA_TYPES_MACHINETOOL_WORKSPACETYPE]);
      |                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                         UA_TYPES_MACHINETOOL_PARTQUALITY
/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c:3535:73: note: each undeclared identifier is reported only once for each function it appears in

@GoetzGoerisch
Copy link
Member

The original Error seems to be gone, but now GMS has a problem:

True, I'm currently investigating if related to NodeSet or open62541 Generator. Because the GMS nodeset currently processed is the RC NodeSet.

Thanks for looking.

@GoetzGoerisch GoetzGoerisch force-pushed the renovate/deps-open62541-digest branch from dbfea31 to 7880088 Compare July 7, 2023 12:48
@GoetzGoerisch
Copy link
Member

GoetzGoerisch commented Jul 7, 2023

If adjusted to the release versions of Machinery/Result and GMS the following error remains:

[ 36%] Building C object CMakeFiles/ua_gen_gms.dir/src_generated/namespace_gms_generated.c.o
/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c: In function β€˜function_namespace_gms_generated_87_begin’:
/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c:2815:72: error: β€˜UA_TYPES_MACHINERY_RESULTDATATYPE’ undeclared (first use in this function); did you mean β€˜UA_TYPES_MACHINERY_RESULT_RESULTDATATYPE’?
 2815 | UA_init(variablenode_ns_6_i_6058_ResultDataType_0, &UA_TYPES_MACHINERY[UA_TYPES_MACHINERY_RESULTDATATYPE]);
      |                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                        UA_TYPES_MACHINERY_RESULT_RESULTDATATYPE
/home/runner/work/Sample-Server/Sample-Server/Sample-Server/src_generated/namespace_gms_generated.c:2815:72: note: each undeclared identifier is reported only once for each function it appears in

@NoelGraf I suspect the the new nodeset generator cannot deal with the .../UA/Machinery/Result/ NSUri?

@NoelGraf
Copy link

NoelGraf commented Jul 8, 2023

I tried to build the gms nodeset and it worked.
I overwrote the plcopen example and loaded gms. This is the cmake and source file.
CMakeLists.txt
server_nodeset_plcopen.c.txt

@GoetzGoerisch
Copy link
Member

Thank you @NoelGraf! Will investigate further.

@GoetzGoerisch GoetzGoerisch force-pushed the renovate/deps-open62541-digest branch from 960bf8f to c9af2bb Compare July 10, 2023 11:06
@GoetzGoerisch GoetzGoerisch force-pushed the renovate/deps-open62541-digest branch 2 times, most recently from 04e54f4 to a272d40 Compare July 27, 2023 08:12
@ccvca ccvca force-pushed the renovate/deps-open62541-digest branch 3 times, most recently from 06b87a7 to c396dc0 Compare August 4, 2023 05:02
@ccvca
Copy link
Member

ccvca commented Aug 4, 2023

The Machinery Result bsd-File (and xsd) does not specify a type for ResultMetaData member, so a fixed version needs to be providede:

<opc:Field TypeName="tns:ResultMetaDataType" Name="ResultMetaData"/>

The original enum has been removed, the author of this may need to change this to the updated values.

/// \todo Must be updated to release specification
//sensor1.Capabilities->push_back(UA_ToolCapabilities::UA_TOOLCAPABILITIES_PTMEAS);

@ccvca ccvca force-pushed the renovate/deps-open62541-digest branch from c396dc0 to cc5caaf Compare August 4, 2023 05:15
@GoetzGoerisch GoetzGoerisch force-pushed the renovate/deps-open62541-digest branch 2 times, most recently from 23f4bb0 to 28c1d65 Compare August 4, 2023 06:36
@GoetzGoerisch GoetzGoerisch added this pull request to the merge queue Aug 4, 2023
Merged via the queue into develop with commit a94b2f2 Aug 4, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants